Page MenuHomeFreeBSD

add new committer information for mmoll@
ClosedPublic

Authored by mmoll on Apr 26 2015, 12:36 AM.
Tags
None
Referenced Files
F103915398: D2371.diff
Sun, Dec 1, 4:06 AM
Unknown Object (File)
Sun, Nov 24, 8:12 PM
Unknown Object (File)
Fri, Nov 8, 1:39 PM
Unknown Object (File)
Oct 20 2024, 6:58 AM
Unknown Object (File)
Oct 20 2024, 6:58 AM
Unknown Object (File)
Oct 20 2024, 6:58 AM
Unknown Object (File)
Oct 20 2024, 6:57 AM
Unknown Object (File)
Oct 20 2024, 6:57 AM
Subscribers
None

Details

Reviewers
swills
mat
Summary

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mmoll retitled this revision from to add new commiter information for mmoll@.
mmoll added reviewers: swills, mat.
mmoll retitled this revision from add new commiter information for mmoll@ to add new committer information for mmoll@.Apr 26 2015, 12:44 AM
mmoll updated this object.
swills edited edge metadata.

Approved

This revision is now accepted and ready to land.Apr 26 2015, 1:11 AM
mat requested changes to this revision.Apr 26 2015, 11:36 AM
mat edited edge metadata.

Sorry, no, the gnupg file is not good.

This revision now requires changes to proceed.Apr 26 2015, 11:36 AM
mmoll edited edge metadata.
mmoll edited edge metadata.
mmoll updated this object.

add XML to GPG key

The XML of the key file should now be OK, or did you mean the non-expiring key?

Subversion seems to think that the file is a binary, and it has a non standard svn:mime-type. Please, svn rm it, and add it again, the only property it should have is svn:keywords with FreeBSD=%H.

Something more like:

$ svn pl -v mat.key
Properties on 'mat.key':
  svn:keywords
    FreeBSD=%H
mmoll edited edge metadata.

add $FreeBSD$ to GPG key and use svn propset

I added $FreeBSD$ to the key file and had to use svn propset still. Maybe SVN is outsmarting itself here with the mime-type?

In D2371#43211, @mmoll wrote:

I added $FreeBSD$ to the key file and had to use svn propset still. Maybe SVN is outsmarting itself here with the mime-type?

Please, use the addkey.sh script to generate the file, it will do that the right way, and it would have told you what commands to run to add the file.

import key with addkey.sh

share/xml/authors.ent
1465

There, I'd say there's a &a.mm; that should be &a.mmoll;

mmoll added inline comments.
share/xml/authors.ent
1465

indeed

mmoll marked an inline comment as done.

copypasto

mat edited edge metadata.

Ok, looks good now :-)

This revision is now accepted and ready to land.Apr 26 2015, 1:54 PM

Quite a journey... commited as r46599 , thanks! :)

In D2371#43229, @mmoll wrote:

Quite a journey... commited as r46599 , thanks! :)

If you write rD46599 you get a link to the actual commit :-)