The disk access is validated by using partition table definitions, therefore
we have no need for if statements, just set the disk size.
Of course the partition table itself may be incorrect/inconsistent, but if
so, we are in trouble anyhow.
Details
Details
- Reviewers
- None
- Commits
- rS341226: MFC r340215:
rS340215: loader: always set media size from partition.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20606 Build 20027: arc lint + arc unit
Event Timeline
Comment Actions
Seems legit to me. I like the abstraction even if we don't determine the size in multiple places.
| stand/i386/libi386/biosdisk.c | ||
|---|---|---|
| 445 | Typo: mulitplication | |
| stand/i386/libi386/biosdisk.c | ||
|---|---|---|
| 445 | Yes, thanks:) | |