Page MenuHomeFreeBSD
Differential D17669

security/fswatch: Take maintainership & clean up
ClosedPublic
Actions

Authored by 0mp on Oct 23 2018, 4:50 PM.
Tags
None
Referenced Files
F97614601: D17669.diff
Mon, Sep 30, 9:18 AM
Unknown Object (File)
Sat, Sep 28, 7:20 PM
Unknown Object (File)
Sat, Sep 28, 6:05 PM
Unknown Object (File)
Sat, Sep 28, 3:45 AM
Unknown Object (File)
Fri, Sep 27, 8:05 PM
Unknown Object (File)
Fri, Sep 27, 6:23 AM
Unknown Object (File)
Thu, Sep 26, 7:55 AM
Unknown Object (File)
Thu, Sep 26, 7:55 AM
View All 76 Files
Subscribers
None

Details

Reviewers
krion
mat
Commits
rP482848: security/fswatch: Take maintainership & clean up
Summary
  • Take maintainership
  • Remove now empty files/
  • Do not use SUB_FILES for pkg-message as there is nothing to substitute
  • Set LICENSE and LICENSE_FILE
  • Sort variables
  • Do not set WRKSRC as it is not necessary
  • Reword pkg-message
  • Use @sample for a sample configuration file
Test Plan
  • portlint
  • poudirere
    • amd64
      • 11.2
      • 12.0-BETA1
      • 12.0-ALPHA9
    • i386
      • 11.2

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20363
Build 19804: arc lint + arc unit

Event Timeline

0mp created this revision.Oct 23 2018, 4:50 PM
Harbormaster completed remote builds in B20361: Diff 49516.Oct 23 2018, 4:50 PM
krion requested changes to this revision.Oct 23 2018, 5:12 PM
krion added inline comments.
security/fswatch/pkg-plist
5

Bump PORTREVISION for this change.

This revision now requires changes to proceed.Oct 23 2018, 5:12 PM
0mp updated this revision to Diff 49518.Oct 23 2018, 5:17 PM

Bump PORTREVISION.

Harbormaster completed remote builds in B20363: Diff 49518.Oct 23 2018, 5:17 PM
krion accepted this revision.Oct 23 2018, 5:18 PM
This revision is now accepted and ready to land.Oct 23 2018, 5:18 PM
0mp requested review of this revision.Oct 23 2018, 5:19 PM
0mp marked 2 inline comments as done.
0mp added inline comments.
security/fswatch/pkg-plist
5

Good catch. Thanks.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 23 2018, 5:23 PM
Closed by commit rP482848: security/fswatch: Take maintainership & clean up (authored by 0mp). · Explain Why
This revision was automatically updated to reflect the committed changes.
0mp marked an inline comment as done.

Revision Contents
Changeset List

PathSize
security/
fswatch/
12 lines
1 line
pkg-message/
files/
pkg-message.in
7 lines
2 lines

Diff 49518

View Options

security/fswatch/Makefile

Loading...
View Options

security/fswatch/distinfo

Loading...
View Options

security/fswatch/files/

Loading...
View Options

security/fswatch/files/pkg-message.in

Loading...
View Options

security/fswatch/pkg-message

Loading...
View Options

security/fswatch/pkg-plist

Loading...