readelf: avoid division by zero for files with invalid sh_entsize
ClosedPublic
Actions

Authored by emaste on Apr 20 2015, 8:43 PM.

Details

Reviewers

brooks

Commits

rS285845: readelf: avoid division by zero on section entry size

Summary

Variations reported in:
https://sourceforge.net/p/elftoolchain/tickets/439
https://sourceforge.net/p/elftoolchain/tickets/444
https://sourceforge.net/p/elftoolchain/tickets/445
https://sourceforge.net/p/elftoolchain/tickets/467

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 4930.Apr 20 2015, 8:43 PM

emaste retitled this revision from to readelf: avoid division by zero for files with invalid sh_entsize.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a subscriber: Unknown Object (MLST).

Looks good to me.

This revision is now accepted and ready to land.Apr 20 2015, 8:50 PM

Add a get_ent_count helper to check for 0 entsize instead of expanding the check inline everywhere.

This revision now requires review to proceed.Jul 19 2015, 11:13 AM

Is this still live?

Yes - sorry for the delay. I realized I had a newer implementation that factored the divide-by-zero checks into a helper function, and uploaded the new diff a few days ago.

Looks good to me.

This revision is now accepted and ready to land.Jul 23 2015, 7:32 PM

Closed by commit rS285845: readelf: avoid division by zero on section entry size (authored by emaste). · Explain WhyJul 24 2015, 6:01 PM

This revision was automatically updated to reflect the committed changes.

Upstream commit here: https://sourceforge.net/p/elftoolchain/code/3227/

Revision Contents
Changeset List

Path

Size

readelf/

readelf.c

32 lines

Diff 4930

View Options

readelf: avoid division by zero for files with invalid sh_entsizeClosedPublicActions