Page MenuHomeFreeBSD
Differential D17294

x11-themes/sddm-freebsd-black-theme: update to version 1.2.
ClosedPublic
Actions

Authored by rigoletto on Sep 22 2018, 6:07 PM.
Tags
None
Referenced Files
F105096488: D17294.diff
Thu, Dec 12, 8:56 AM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
Unknown Object (File)
Fri, Dec 6, 11:54 PM
View All Files
Subscribers
None

Details

Reviewers
tcberner
mat
Commits
rP482016: x11-themes/sddm-freebsd-black-theme: update to version 1.2.
Summary
  • update to version 1.2
  • update MAINTAINER
  • update MASTER_SITES

Thanks!

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19760
Build 19315: arc lint + arc unit

Event Timeline

rigoletto created this revision.Sep 22 2018, 6:07 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 22 2018, 6:07 PM
Harbormaster completed remote builds in B19759: Diff 48364.Sep 22 2018, 6:07 PM
tcberner added inline comments.Sep 22 2018, 8:18 PM
x11-themes/sddm-freebsd-black-theme/pkg-plist
1 ↗(On Diff #48364)

you stopped using THEMEDIR :) you can either get rid of it in the makefile or keep using it.

rigoletto updated this revision to Diff 48365.Sep 22 2018, 8:35 PM
rigoletto marked 2 inline comments as done.

Done.

Harbormaster completed remote builds in B19760: Diff 48365.Sep 22 2018, 8:35 PM
rigoletto added inline comments.Sep 22 2018, 8:35 PM
x11-themes/sddm-freebsd-black-theme/pkg-plist
1 ↗(On Diff #48364)

I was looking for better readability on the pkg-plist file, but removing it from the port would make it uglier to read. ^^

rigoletto retitled this revision from n11-themes/sddm-freebsd-black-theme: update to version 1.1. to x11-themes/sddm-freebsd-black-theme: update to version 1.1..Sep 22 2018, 8:38 PM
mat added inline comments.Sep 24 2018, 12:09 PM
x11-themes/sddm-freebsd-black-theme/Makefile
20–28

All those changes should probably not be made.

32–38

Remove whitespace changes. Also, INSTALL_DATA.

rigoletto updated this revision to Diff 48408.Sep 24 2018, 7:25 PM
rigoletto marked 2 inline comments as done.

Done.

Harbormaster completed remote builds in B19782: Diff 48408.Sep 24 2018, 7:25 PM
rigoletto updated this revision to Diff 48702.Oct 4 2018, 4:38 AM

Updating MAINTAINER.

Harbormaster completed remote builds in B19947: Diff 48702.Oct 4 2018, 4:38 AM
rigoletto updated this revision to Diff 48845.Oct 7 2018, 2:01 AM

While here switch MASTER_SITES to the new source address..

Harbormaster completed remote builds in B20043: Diff 48845.Oct 7 2018, 2:01 AM
rigoletto retitled this revision from x11-themes/sddm-freebsd-black-theme: update to version 1.1. to x11-themes/sddm-freebsd-black-theme: update to version 1.2..Oct 7 2018, 2:15 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto added a reviewer: mat.
rigoletto removed a subscriber: mat.
rigoletto edited the summary of this revision. (Show Details)Oct 7 2018, 2:19 AM
mat added inline comments.Oct 8 2018, 3:29 PM
x11-themes/sddm-freebsd-black-theme/Makefile
24–25

There are locally defined variables, they go after the options block. See Order of Variables in Port Makefiles.

30

This is a standard variable, it goes before the options. See Order of Variables in Port Makefiles.

mat added a comment.Oct 8 2018, 3:31 PM

Also, please provide a tentative commit message in your reviews.

rigoletto updated this revision to Diff 48919.Oct 9 2018, 3:38 AM
rigoletto marked 2 inline comments as done.

Done.

Harbormaster completed remote builds in B20080: Diff 48919.Oct 9 2018, 3:38 AM
rigoletto added a comment.Oct 9 2018, 8:36 PM

x11-themes/sddm-freebsd-black-theme: update to version 1.2

Update MAINTAINER address.

Approved by: tcberner (mentor), mat (mentor)

mat added inline comments.Oct 13 2018, 2:24 PM
x11-themes/sddm-freebsd-black-theme/Makefile
28–29

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

rigoletto updated this revision to Diff 49108.Oct 13 2018, 7:32 PM

Re-organized.

Harbormaster completed remote builds in B20181: Diff 49108.Oct 13 2018, 7:32 PM
rigoletto updated this revision to Diff 49111.Oct 13 2018, 8:30 PM
rigoletto marked an inline comment as done.

Re-ordering again.

Harbormaster completed remote builds in B20184: Diff 49111.Oct 13 2018, 8:30 PM
mat accepted this revision.Oct 13 2018, 9:07 PM
This revision is now accepted and ready to land.Oct 13 2018, 9:07 PM
Closed by commit rP482016: x11-themes/sddm-freebsd-black-theme: update to version 1.2. (authored by rigoletto). · Explain WhyOct 13 2018, 9:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
x11-themes/
sddm-freebsd-black-theme/
26 lines
6 lines

Diff 48365

View Options

x11-themes/sddm-freebsd-black-theme/Makefile

Loading...
View Options

x11-themes/sddm-freebsd-black-theme/distinfo

Loading...