mail/mblaze: Unix utilities to deal with Maildir
ClosedPublic
Actions

Authored by loader on Aug 17 2018, 8:19 AM.

Details

Reviewers

koobs

Commits

rP477630: [NEW PORT]: mail/mblaze: Unix utilities to deal with Maildir

Summary

Proposed commit log message:

[NEW PORT]: mail/mblaze: Unix utilities to deal with Maildir

The mblaze message system is a set of Unix utilities for processing and
interacting with mail messages which are stored in maildir folders.

WWW: https://github.com/chneukirchen/mblaze

Reviewed_by: koobs, mat
Approved by: koobs (mentor)
Differential_Revision: D16759

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 1200075, [armv7, aarch64, amd64], '', '' tested)
unittest: OK (

armv7: All tests successful.
aarch64: All tests successful.
amd64: All tests successful.
)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18882
Build 18536: arc lint + arc unit

Event Timeline

loader created this revision.Aug 17 2018, 8:19 AM

Herald added a subscriber: mat. · View Herald TranscriptAug 17 2018, 8:19 AM

Harbormaster completed remote builds in B18882: Diff 46822.Aug 17 2018, 8:19 AM

loader edited the summary of this revision. (Show Details)Aug 17 2018, 8:21 AM

loader retitled this revision from mail/mblaze: Unix utilities to deal with Maildir<<Replace this line with your revision title> to mail/mblaze: Unix utilities to deal with Maildir.

mat added inline comments.Aug 17 2018, 9:17 AM

mail/mblaze/Makefile
13	With multiple licenses, `LICENSE_FILE` gets applied to all licenses. It is best to always set `LICENSE_FILE_<license>`.
mail/mblaze/files/patch-GNUmakefile
8	This is so wrong. `PREFIX` is where the port installs itself `LOCALBASE` is where the port dependencies are installed.

replace ${LOCALBASE} with ${PREFIX}

Harbormaster completed remote builds in B18886: Diff 46827.Aug 17 2018, 10:01 AM

loader marked an inline comment as done.Aug 17 2018, 10:08 AM

loader added inline comments.

mail/mblaze/Makefile
13	Actually, those licenses are just mentioned in this file, should I delete the LICENSE_FILE line? https://github.com/chneukirchen/mblaze/blob/master/COPYING
mail/mblaze/files/patch-GNUmakefile
8	Okay, thanks @mat.

loader marked an inline comment as done.Aug 17 2018, 10:11 AM

mat added inline comments.Aug 17 2018, 10:43 AM

mail/mblaze/Makefile
13	LICENSE_FILE(_*) should point to a file actually containing the licenses, so, yes, removing it would probably be better.
mail/mblaze/files/patch-GNUmakefile
21–22	It would be better to use ${BSD_INSTALL_PROGRAM} and ${BSD_INSTALL_SCRIPT} so that this respects debug and strip flags.