newsyslog: fix compression arglist construction
ClosedPublic
Actions

Authored by dnelson_1901_yahoo.com on Jul 30 2018, 3:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 4, 6:09 PM

	Unknown Object (File)
	Tue, Dec 30, 6:27 PM

	Unknown Object (File)
	Mon, Dec 29, 9:15 AM

	Unknown Object (File)
	Sat, Dec 27, 10:53 AM

	Unknown Object (File)
	Nov 20 2025, 10:26 PM

	Unknown Object (File)
	Nov 20 2025, 10:26 PM

	Unknown Object (File)
	Nov 20 2025, 10:25 PM

	Unknown Object (File)
	Nov 20 2025, 10:19 PM

View All 97 Files

Subscribers

imp

Details

Reviewers

bapt

Commits

rS336913: newsyslog: fix compression arglist construction

Summary

Reuse of the index variable in two nested loops resulted in only the first
argument in the list being used (fine for gzip, not fine for zstd). Also
add tests for xz and zstd, and fix the COMPRESS_SUFFIX_MAXLEN macro.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18434
Build 18142: arc lint + arc unit

Event Timeline

dnelson_1901_yahoo.com created this revision.Jul 30 2018, 3:13 PM

Harbormaster completed remote builds in B18434: Diff 46024.Jul 30 2018, 3:13 PM

dnelson_1901_yahoo.com set the repository for this revision to rS FreeBSD src repository - subversion.Jul 30 2018, 3:25 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2018, 3:25 PM

bapt accepted this revision.Jul 30 2018, 3:45 PM

This revision is now accepted and ready to land.Jul 30 2018, 3:45 PM

Closed by commit rS336913: newsyslog: fix compression arglist construction (authored by bapt). · Explain WhyJul 30 2018, 3:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

newsyslog/

newsyslog.c

10 lines

tests/

legacy_test.sh

24 lines

Diff 46024

View Options

usr.sbin/newsyslog/newsyslog.c