Page MenuHomeFreeBSD
Differential D14014

Fix PLIST_SUB being too big and PLIST_SUB_SED getting bigger than _POSIX2_LINE_MAX.
ClosedPublic
Actions

Authored by mat on Jan 22 2018, 2:26 PM.
Tags
None
Referenced Files
F86099125: D14014.id.diff
Sat, Jun 15, 10:52 AM
Unknown Object (File)
May 13 2024, 2:12 PM
Unknown Object (File)
May 10 2024, 8:16 AM
Unknown Object (File)
May 8 2024, 12:39 AM
Unknown Object (File)
May 3 2024, 11:24 AM
Unknown Object (File)
Feb 10 2024, 9:34 PM
Unknown Object (File)
Feb 2 2024, 10:46 PM
Unknown Object (File)
Dec 21 2023, 10:16 PM
View All 36 Files
Subscribers
asomers

Details

Reviewers
asomers
Group Reviewers
portmgr
Commits
rP475361: Extract PLIST_SUB substitutions into a sed script.
Summary

And it fixes it by putting everything from PLIST_SUB_SED into a file and asking sed to read that file.

Fixes the problem from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222355

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18228
Build 17956: arc lint + arc unit

Event Timeline

mat created this revision.Jan 22 2018, 2:26 PM
Harbormaster completed remote builds in B14523: Diff 38308.Jan 22 2018, 2:26 PM
mat edited the summary of this revision. (Show Details)Jan 22 2018, 2:29 PM
asomers added a subscriber: asomers.Jan 22 2018, 6:17 PM

I can no longer reproduce the original issue. Something in my environment changed and now sed's command line is just under the limit. However, i can confirm that this patch doesn't break anything at least.

mat updated this revision to Diff 45646.Jul 21 2018, 9:22 AM
mat edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B18228: Diff 45646.Jul 21 2018, 9:22 AM
asomers accepted this revision.Jul 21 2018, 5:03 PM

With an up-to-date ports tree and an 11.1 jail, www/rubygem-passenger works just fine but textproc/rubygem-gitlab-markup fails as reported. With the patch, both ports work fine.

This revision is now accepted and ready to land.Jul 21 2018, 5:03 PM
Closed by commit rP475361: Extract PLIST_SUB substitutions into a sed script. (authored by mat). · Explain WhyJul 26 2018, 11:10 AM
This revision was automatically updated to reflect the committed changes.
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptJul 26 2018, 11:10 AM

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
22 lines
6 lines
2 lines

Diff 45646

View Options

Mk/Scripts/check-stagedir.sh

Loading...
View Options

Mk/Scripts/check_leftovers.sh

Loading...
View Options

Mk/Scripts/plist_sub_sed_sort.sh

Loading...