Page MenuHomeFreeBSD
Differential D16340

net/tigervnc: update 1.8.0 -> 1.9.0 While here, * Adjust USE_XROG
ClosedPublic
Actions

Authored by meta on Jul 19 2018, 3:03 AM.
Tags
None
Referenced Files
F151014010: D16340.id45512.diff
Sun, Apr 5, 11:22 AM
F151012358: D16340.id45575.diff
Sun, Apr 5, 11:11 AM
F150977027: D16340.id45511.diff
Sun, Apr 5, 6:43 AM
Unknown Object (File)
Sat, Apr 4, 5:09 PM
Unknown Object (File)
Sat, Apr 4, 4:30 PM
Unknown Object (File)
Sat, Apr 4, 2:01 PM
Unknown Object (File)
Sat, Apr 4, 3:11 AM
Unknown Object (File)
Thu, Apr 2, 2:50 AM
View All Files
Subscribers
None

Details

Reviewers
pi
hrs
Commits
rP474993: net/tigervnc: update 1.8.0 -> 1.9.0
Summary

Approved by: ? (mentor)
Relnotes: https://github.com/TigerVNC/tigervnc/releases/tag/v1.9.0
#Differential Revision:

I'm planning to separate the port into tigervnc-server and tigervnc-viewer
but just updating at this time.

Test Plan
  • no new warnings by portlint -AC
  • poudriere testbuild finished successfully @112amd64
  • confirmed it actually works

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18154
Build 17889: arc lint + arc unit

Event Timeline

meta created this revision.Jul 19 2018, 3:03 AM
Harbormaster completed remote builds in B18152: Diff 45511.Jul 19 2018, 3:03 AM
meta updated this revision to Diff 45512.Jul 19 2018, 3:13 AM

regenerate patches

Harbormaster completed remote builds in B18153: Diff 45512.Jul 19 2018, 3:13 AM
meta updated this revision to Diff 45513.Jul 19 2018, 3:14 AM

remove other port's diff

Harbormaster completed remote builds in B18154: Diff 45513.Jul 19 2018, 3:14 AM
meta updated this revision to Diff 45574.Jul 20 2018, 2:37 AM

remove tridiavnc from CONFLICTS since the port no longer exists

Harbormaster completed remote builds in B18189: Diff 45574.Jul 20 2018, 2:37 AM
meta updated this revision to Diff 45575.Jul 20 2018, 2:38 AM

remove tridiavnc from CONFLICTS

Harbormaster completed remote builds in B18190: Diff 45575.Jul 20 2018, 2:38 AM
pi accepted this revision.Jul 20 2018, 7:19 AM

I've test-build, and it looks good. Two small things:

  • The USES-line is almost 80chars long and already has a \ to the following line. Can you move one more element to the next line ?
  • The IGNORE for -devel needs to higher up in the Makefile, see portlint's complaints
This revision is now accepted and ready to land.Jul 20 2018, 7:19 AM
meta updated this revision to Diff 45587.Jul 20 2018, 8:07 AM
  • bring IGNORE line earlier
  • more one more USES element to the next line
This revision now requires review to proceed.Jul 20 2018, 8:07 AM
Harbormaster completed remote builds in B18197: Diff 45587.Jul 20 2018, 8:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 20 2018, 8:17 AM
Closed by commit rP474993: net/tigervnc: update 1.8.0 -> 1.9.0 (authored by meta). · Explain Why
This revision was automatically updated to reflect the committed changes.
meta added a comment.Jul 20 2018, 8:46 AM

Committed, thanks for your review.

Revision Contents
Changeset List

PathSize
net/
tigervnc-devel/
9 lines
6 lines
files/
4 lines
4 lines
2 lines
5 lines
tigervnc/
7 lines
6 lines
files/
4 lines
6 lines
4 lines

Diff 45513

View Options

net/tigervnc-devel/Makefile

Loading...
View Options

net/tigervnc-devel/distinfo

Loading...
View Options

net/tigervnc-devel/files/patch-CMakeLists.txt

Loading...
View Options

net/tigervnc-devel/files/patch-cmake_BuildPackages.cmake

Loading...
View Options

net/tigervnc-devel/files/patch-unix_vncserver

Loading...
View Options

net/tigervnc-devel/pkg-plist

Loading...
View Options

net/tigervnc/Makefile

Loading...
View Options

net/tigervnc/distinfo

Loading...
View Options

net/tigervnc/files/patch-CMakeLists.txt

Loading...
View Options

net/tigervnc/files/patch-cmake_BuildPackages.cmake

Loading...
View Options

net/tigervnc/pkg-plist

Loading...