Page MenuHomeFreeBSD
Differential D16340

net/tigervnc: update 1.8.0 -> 1.9.0 While here, * Adjust USE_XROG
ClosedPublic
Actions

Authored by meta on Jul 19 2018, 3:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 8:24 AM
Unknown Object (File)
Mon, Apr 14, 4:33 AM
Unknown Object (File)
Mon, Apr 14, 12:33 AM
Unknown Object (File)
Sun, Apr 13, 11:45 PM
Unknown Object (File)
Sun, Apr 13, 10:51 PM
Unknown Object (File)
Sun, Apr 13, 10:12 PM
Unknown Object (File)
Sun, Apr 13, 9:47 PM
Unknown Object (File)
Sun, Apr 13, 9:14 PM
View All Files
Subscribers
None

Details

Reviewers
pi
hrs
Commits
rP474993: net/tigervnc: update 1.8.0 -> 1.9.0
Summary

Approved by: ? (mentor)
Relnotes: https://github.com/TigerVNC/tigervnc/releases/tag/v1.9.0
#Differential Revision:

I'm planning to separate the port into tigervnc-server and tigervnc-viewer
but just updating at this time.

Test Plan
  • no new warnings by portlint -AC
  • poudriere testbuild finished successfully @112amd64
  • confirmed it actually works

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18154
Build 17889: arc lint + arc unit

Event Timeline

meta created this revision.Jul 19 2018, 3:03 AM
Harbormaster completed remote builds in B18152: Diff 45511.Jul 19 2018, 3:03 AM
meta updated this revision to Diff 45512.Jul 19 2018, 3:13 AM

regenerate patches

Harbormaster completed remote builds in B18153: Diff 45512.Jul 19 2018, 3:13 AM
meta updated this revision to Diff 45513.Jul 19 2018, 3:14 AM

remove other port's diff

Harbormaster completed remote builds in B18154: Diff 45513.Jul 19 2018, 3:14 AM
meta updated this revision to Diff 45574.Jul 20 2018, 2:37 AM

remove tridiavnc from CONFLICTS since the port no longer exists

Harbormaster completed remote builds in B18189: Diff 45574.Jul 20 2018, 2:37 AM
meta updated this revision to Diff 45575.Jul 20 2018, 2:38 AM

remove tridiavnc from CONFLICTS

Harbormaster completed remote builds in B18190: Diff 45575.Jul 20 2018, 2:38 AM
pi accepted this revision.Jul 20 2018, 7:19 AM

I've test-build, and it looks good. Two small things:

  • The USES-line is almost 80chars long and already has a \ to the following line. Can you move one more element to the next line ?
  • The IGNORE for -devel needs to higher up in the Makefile, see portlint's complaints
This revision is now accepted and ready to land.Jul 20 2018, 7:19 AM
meta updated this revision to Diff 45587.Jul 20 2018, 8:07 AM
  • bring IGNORE line earlier
  • more one more USES element to the next line
This revision now requires review to proceed.Jul 20 2018, 8:07 AM
Harbormaster completed remote builds in B18197: Diff 45587.Jul 20 2018, 8:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 20 2018, 8:17 AM
Closed by commit rP474993: net/tigervnc: update 1.8.0 -> 1.9.0 (authored by meta). · Explain Why
This revision was automatically updated to reflect the committed changes.
meta added a comment.Jul 20 2018, 8:46 AM

Committed, thanks for your review.

Revision Contents
Changeset List

PathSize
net/
tigervnc-devel/
9 lines
6 lines
files/
4 lines
4 lines
2 lines
5 lines
tigervnc/
7 lines
6 lines
files/
4 lines
6 lines
4 lines

Diff 45513

View Options

net/tigervnc-devel/Makefile

# Created by: Olivier Duchateau # Created by: Olivier Duchateau
# $FreeBSD$ # $FreeBSD$
PORTNAME= libdbusmenu PORTNAME= libdbusmenu
PORTVERSION= 16.04.0 PORTVERSION= 16.04.0
PORTREVISION= 1
CATEGORIES= devel CATEGORIES= devel
MASTER_SITES= https://launchpadlibrarian.net/243440794/ \ MASTER_SITES= https://launchpadlibrarian.net/243440794/ \
https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/ https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= GLib and Gtk Implementation of the DBusMenu protocol COMMENT= GLib and Gtk Implementation of the DBusMenu protocol
LICENSE= GPLv3 LGPL21 LGPL3 LICENSE= GPLv3 LGPL21 LGPL3
LICENSE_COMB= multi LICENSE_COMB= multi
LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING
LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3 LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3
LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1 LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1
BUILD_DEPENDS= vapigen:lang/vala \ BUILD_DEPENDS= vapigen:lang/vala \
gtkdoc-check:textproc/gtk-doc gtkdoc-check:textproc/gtk-doc
LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib
GNU_CONFIGURE= yes GNU_CONFIGURE= yes
USES= gmake libtool pathfix pkgconfig USES= gmake libtool pathfix pkgconfig python:run shebangfix
USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \ USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \
introspection:build gtk30 introspection:build gtk30
USE_XORG= x11 USE_XORG= x11
USE_LDCONFIG= yes USE_LDCONFIG= yes
INSTALL_TARGET= install-strip INSTALL_TARGET= install-strip
SHEBANG_FILES= tools/dbusmenu-bench
matUnsubmitted
Not Done
Inline Actions

So you are adding python as a dependency so that a tool that nobody will ever use gets the right shebang ? It is ludicrous, please don't.

mat: So you are adding python as a dependency so that a tool that nobody will ever use gets the…
tcbernerAuthorUnsubmitted
Not Done
Inline Actions

according to INDEX it depends on python anyways, no?

So should this shebang error just be ignored?

tcberner: according to INDEX it depends on python anyways, no? So should this shebang error just be…
matUnsubmitted
Not Done
Inline Actions

There are talks about reducing the pain for the python interpreter shebang thing, only if the port depends on python.

Now, if this already has python as a run dependencies through some dependency, it may be ok. Be sure to say so when you commit it.

mat: There are talks about reducing the pain for the python interpreter shebang thing, only if the…
PLIST_SUB= VERSION="0.4" PLIST_SUB= VERSION="0.4"
CONFIGURE_ARGS= --disable-static \ CONFIGURE_ARGS= --disable-static \
--disable-static \ --disable-static \
--disable-dumper \ --disable-dumper \
--disable-tests \ --disable-tests \
--disable-massivedebugging \ --disable-massivedebugging \
--enable-introspection=yes \ --enable-introspection=yes \
--disable-nls \ --disable-nls \
--enable-vala \ --enable-vala \
--with-gtk=3 --with-gtk=3
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

net/tigervnc-devel/distinfo

# Created by: Olivier Duchateau # Created by: Olivier Duchateau
# $FreeBSD$ # $FreeBSD$
PORTNAME= libdbusmenu PORTNAME= libdbusmenu
PORTVERSION= 16.04.0 PORTVERSION= 16.04.0
PORTREVISION= 1
CATEGORIES= devel CATEGORIES= devel
MASTER_SITES= https://launchpadlibrarian.net/243440794/ \ MASTER_SITES= https://launchpadlibrarian.net/243440794/ \
https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/ https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= GLib and Gtk Implementation of the DBusMenu protocol COMMENT= GLib and Gtk Implementation of the DBusMenu protocol
LICENSE= GPLv3 LGPL21 LGPL3 LICENSE= GPLv3 LGPL21 LGPL3
LICENSE_COMB= multi LICENSE_COMB= multi
LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING
LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3 LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3
LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1 LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1
BUILD_DEPENDS= vapigen:lang/vala \ BUILD_DEPENDS= vapigen:lang/vala \
gtkdoc-check:textproc/gtk-doc gtkdoc-check:textproc/gtk-doc
LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib
GNU_CONFIGURE= yes GNU_CONFIGURE= yes
USES= gmake libtool pathfix pkgconfig USES= gmake libtool pathfix pkgconfig python:run shebangfix
USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \ USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \
introspection:build gtk30 introspection:build gtk30
USE_XORG= x11 USE_XORG= x11
USE_LDCONFIG= yes USE_LDCONFIG= yes
INSTALL_TARGET= install-strip INSTALL_TARGET= install-strip
SHEBANG_FILES= tools/dbusmenu-bench
matUnsubmitted
Not Done
Inline Actions

So you are adding python as a dependency so that a tool that nobody will ever use gets the right shebang ? It is ludicrous, please don't.

mat: So you are adding python as a dependency so that a tool that nobody will ever use gets the…
tcbernerAuthorUnsubmitted
Not Done
Inline Actions

according to INDEX it depends on python anyways, no?

So should this shebang error just be ignored?

tcberner: according to INDEX it depends on python anyways, no? So should this shebang error just be…
matUnsubmitted
Not Done
Inline Actions

There are talks about reducing the pain for the python interpreter shebang thing, only if the port depends on python.

Now, if this already has python as a run dependencies through some dependency, it may be ok. Be sure to say so when you commit it.

mat: There are talks about reducing the pain for the python interpreter shebang thing, only if the…
PLIST_SUB= VERSION="0.4" PLIST_SUB= VERSION="0.4"
CONFIGURE_ARGS= --disable-static \ CONFIGURE_ARGS= --disable-static \
--disable-static \ --disable-static \
--disable-dumper \ --disable-dumper \
--disable-tests \ --disable-tests \
--disable-massivedebugging \ --disable-massivedebugging \
--enable-introspection=yes \ --enable-introspection=yes \
--disable-nls \ --disable-nls \
--enable-vala \ --enable-vala \
--with-gtk=3 --with-gtk=3
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

net/tigervnc-devel/files/patch-CMakeLists.txt

# Created by: Olivier Duchateau # Created by: Olivier Duchateau
# $FreeBSD$ # $FreeBSD$
PORTNAME= libdbusmenu PORTNAME= libdbusmenu
PORTVERSION= 16.04.0 PORTVERSION= 16.04.0
PORTREVISION= 1
CATEGORIES= devel CATEGORIES= devel
MASTER_SITES= https://launchpadlibrarian.net/243440794/ \ MASTER_SITES= https://launchpadlibrarian.net/243440794/ \
https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/ https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= GLib and Gtk Implementation of the DBusMenu protocol COMMENT= GLib and Gtk Implementation of the DBusMenu protocol
LICENSE= GPLv3 LGPL21 LGPL3 LICENSE= GPLv3 LGPL21 LGPL3
LICENSE_COMB= multi LICENSE_COMB= multi
LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING
LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3 LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3
LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1 LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1
BUILD_DEPENDS= vapigen:lang/vala \ BUILD_DEPENDS= vapigen:lang/vala \
gtkdoc-check:textproc/gtk-doc gtkdoc-check:textproc/gtk-doc
LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib
GNU_CONFIGURE= yes GNU_CONFIGURE= yes
USES= gmake libtool pathfix pkgconfig USES= gmake libtool pathfix pkgconfig python:run shebangfix
USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \ USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \
introspection:build gtk30 introspection:build gtk30
USE_XORG= x11 USE_XORG= x11
USE_LDCONFIG= yes USE_LDCONFIG= yes
INSTALL_TARGET= install-strip INSTALL_TARGET= install-strip
SHEBANG_FILES= tools/dbusmenu-bench
matUnsubmitted
Not Done
Inline Actions

So you are adding python as a dependency so that a tool that nobody will ever use gets the right shebang ? It is ludicrous, please don't.

mat: So you are adding python as a dependency so that a tool that nobody will ever use gets the…
tcbernerAuthorUnsubmitted
Not Done
Inline Actions

according to INDEX it depends on python anyways, no?

So should this shebang error just be ignored?

tcberner: according to INDEX it depends on python anyways, no? So should this shebang error just be…
matUnsubmitted
Not Done
Inline Actions

There are talks about reducing the pain for the python interpreter shebang thing, only if the port depends on python.

Now, if this already has python as a run dependencies through some dependency, it may be ok. Be sure to say so when you commit it.

mat: There are talks about reducing the pain for the python interpreter shebang thing, only if the…
PLIST_SUB= VERSION="0.4" PLIST_SUB= VERSION="0.4"
CONFIGURE_ARGS= --disable-static \ CONFIGURE_ARGS= --disable-static \
--disable-static \ --disable-static \
--disable-dumper \ --disable-dumper \
--disable-tests \ --disable-tests \
--disable-massivedebugging \ --disable-massivedebugging \
--enable-introspection=yes \ --enable-introspection=yes \
--disable-nls \ --disable-nls \
--enable-vala \ --enable-vala \
--with-gtk=3 --with-gtk=3
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

net/tigervnc-devel/files/patch-cmake_BuildPackages.cmake

# Created by: Olivier Duchateau # Created by: Olivier Duchateau
# $FreeBSD$ # $FreeBSD$
PORTNAME= libdbusmenu PORTNAME= libdbusmenu
PORTVERSION= 16.04.0 PORTVERSION= 16.04.0
PORTREVISION= 1
CATEGORIES= devel CATEGORIES= devel
MASTER_SITES= https://launchpadlibrarian.net/243440794/ \ MASTER_SITES= https://launchpadlibrarian.net/243440794/ \
https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/ https://launchpad.net/${PORTNAME}/${PORTVERSION:R}/${PORTVERSION}/+download/
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= GLib and Gtk Implementation of the DBusMenu protocol COMMENT= GLib and Gtk Implementation of the DBusMenu protocol
LICENSE= GPLv3 LGPL21 LGPL3 LICENSE= GPLv3 LGPL21 LGPL3
LICENSE_COMB= multi LICENSE_COMB= multi
LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING LICENSE_FILE_LGPL3= ${WRKSRC}/COPYING
LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3 LICENSE_FILE_GPLv3= ${WRKSRC}/COPYING-GPL3
LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1 LICENSE_FILE_LGPL21= ${WRKSRC}/COPYING.2.1
BUILD_DEPENDS= vapigen:lang/vala \ BUILD_DEPENDS= vapigen:lang/vala \
gtkdoc-check:textproc/gtk-doc gtkdoc-check:textproc/gtk-doc
LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib LIB_DEPENDS= libjson-glib-1.0.so:devel/json-glib
GNU_CONFIGURE= yes GNU_CONFIGURE= yes
USES= gmake libtool pathfix pkgconfig USES= gmake libtool pathfix pkgconfig python:run shebangfix
USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \ USE_GNOME= gnomedocutils:build glib20 intltool intlhack libxslt \
introspection:build gtk30 introspection:build gtk30
USE_XORG= x11 USE_XORG= x11
USE_LDCONFIG= yes USE_LDCONFIG= yes
INSTALL_TARGET= install-strip INSTALL_TARGET= install-strip
SHEBANG_FILES= tools/dbusmenu-bench
matUnsubmitted
Not Done
Inline Actions

So you are adding python as a dependency so that a tool that nobody will ever use gets the right shebang ? It is ludicrous, please don't.

mat: So you are adding python as a dependency so that a tool that nobody will ever use gets the…
tcbernerAuthorUnsubmitted
Not Done
Inline Actions

according to INDEX it depends on python anyways, no?

So should this shebang error just be ignored?

tcberner: according to INDEX it depends on python anyways, no? So should this shebang error just be…
matUnsubmitted
Not Done
Inline Actions

There are talks about reducing the pain for the python interpreter shebang thing, only if the port depends on python.

Now, if this already has python as a run dependencies through some dependency, it may be ok. Be sure to say so when you commit it.

mat: There are talks about reducing the pain for the python interpreter shebang thing, only if the…
PLIST_SUB= VERSION="0.4" PLIST_SUB= VERSION="0.4"
CONFIGURE_ARGS= --disable-static \ CONFIGURE_ARGS= --disable-static \
--disable-static \ --disable-static \
--disable-dumper \ --disable-dumper \
--disable-tests \ --disable-tests \
--disable-massivedebugging \ --disable-massivedebugging \
--enable-introspection=yes \ --enable-introspection=yes \
--disable-nls \ --disable-nls \
--enable-vala \ --enable-vala \
--with-gtk=3 --with-gtk=3
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

net/tigervnc-devel/files/patch-unix_vncserver

Loading...
View Options

net/tigervnc-devel/pkg-plist

Loading...
View Options

net/tigervnc/Makefile

Loading...
View Options

net/tigervnc/distinfo

Loading...
View Options

net/tigervnc/files/patch-CMakeLists.txt

Loading...
View Options

net/tigervnc/files/patch-cmake_BuildPackages.cmake

Loading...
View Options

net/tigervnc/pkg-plist

Loading...