Differential D16215

OpenCrypto: Convert sessions to pointers instead of integers
AbandonedPublic
Actions

Authored by cem on Jul 11 2018, 6:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 1, 6:17 PM

	Unknown Object (File)
	Fri, Jul 31, 9:20 PM

	Unknown Object (File)
	Fri, Jul 31, 9:20 PM

	Unknown Object (File)
	Fri, Jul 31, 6:24 AM

	Unknown Object (File)
	Thu, Jul 30, 8:14 AM

	Unknown Object (File)
	Thu, Jul 30, 12:48 AM

	Unknown Object (File)
	Tue, Jul 21, 12:34 PM

	Unknown Object (File)
	Sat, Jul 18, 3:51 AM

Subscribers

None

Details

Reviewers

Summary

Track session objects in the framework, and pass pointers between the
framework (OCF) and drivers. Avoid lots of redundancy and complexity in
individual drivers.

Inspired by
https://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html .

Test Plan

Proof of concept conversion to pointer sessions owned by OCF, instead of individual drivers.

I haven't converted the bulk of the drivers yet, and these just compile — have not tested yet. Looking for feedback on the general approach before I go bulk converting.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 17965
Build 17719: arc lint + arc unit

Event Timeline

cem created this revision.Jul 11 2018, 6:26 AM

Harbormaster completed remote builds in B17965: Diff 45139.Jul 11 2018, 6:26 AM

cem added a child revision: D16216: ipsec: Convert OCF consumer to pointer-style interface.Jul 11 2018, 6:29 AM

cem added a child revision: D16217: cryptodev: Convert OCF consumer to pointer-style interface.

cem added a child revision: D16218: cryptosoft: Convert driver to pointer-style interface.Jul 11 2018, 6:32 AM

cem added a child revision: D16219: Adapt ccp(4) and aesni(4) drivers to pointer OCF interface.

cem edited the test plan for this revision. (Show Details)Jul 11 2018, 6:35 AM

Rebase over r336269

Harbormaster completed remote builds in B18021: Diff 45264.Jul 14 2018, 2:12 AM

cem abandoned this revision.Jul 18 2018, 12:25 AM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

8 lines

174 lines

33 lines

26 lines

Diff 45139

sys/opencrypto/_cryptodev.h

Loading...

sys/opencrypto/crypto.c

Loading...

sys/opencrypto/cryptodev.h

Loading...

sys/opencrypto/cryptodev_if.m

Loading...