Page MenuHomeFreeBSD
Differential D15651

Update list of options helpers in the Porter's Handbook
ClosedPublic
Actions

Authored by tobik on Jun 2 2018, 5:07 AM.
Tags
None
Referenced Files
F135328858: D15651.id.diff
Sat, Nov 8, 7:24 PM
F135312829: D15651.id.diff
Sat, Nov 8, 3:20 PM
F135312816: D15651.id43305.diff
Sat, Nov 8, 3:20 PM
F135312794: D15651.id43263.diff
Sat, Nov 8, 3:20 PM
F135296978: D15651.diff
Sat, Nov 8, 11:12 AM
Unknown Object (File)
Sat, Oct 25, 7:22 AM
Unknown Object (File)
Mon, Oct 20, 1:46 AM
Unknown Object (File)
Fri, Oct 17, 4:15 PM
View All 64 Files
Subscribers
linimon

Details

Reviewers
mat
Commits
rD51773: Update list of options helpers in the Porter's Handbook
Summary
Update list of options helpers in the Porter's Handbook

Approved by:	?
Differential Revision:	https://reviews.freebsd.org/D?????

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16974
Build 16843: arc lint + arc unit

Event Timeline

tobik created this revision.Jun 2 2018, 5:07 AM
Herald added a reviewer: mat. · View Herald TranscriptJun 2 2018, 5:07 AM
Harbormaster completed remote builds in B16971: Diff 43263.Jun 2 2018, 5:07 AM
mat added inline comments.Jun 2 2018, 9:02 AM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
7186

I disagree with this change. I prefer to let the indentation out of all the shell bits I wrote over the years. Things get moved around, and indentation needs to get added/removed. Any decent text editor can re-indent this in a split second, I'd rather it is kept that way.

tobik updated this revision to Diff 43266.Jun 2 2018, 9:10 AM

Fair enough.

Harbormaster completed remote builds in B16974: Diff 43266.Jun 2 2018, 9:10 AM
linimon added a subscriber: linimon.Jun 3 2018, 1:05 PM
tobik edited the summary of this revision. (Show Details)Jun 4 2018, 7:59 AM
mat accepted this revision.Jun 4 2018, 10:54 AM
This revision is now accepted and ready to land.Jun 4 2018, 10:54 AM
Closed by commit rD51773: Update list of options helpers in the Porter's Handbook (authored by tobik). · Explain WhyJun 4 2018, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
makefiles/
28 lines

Diff 43266

View Options

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml

Loading...