Page MenuHomeFreeBSD
Differential D14722

mail/py-pymailq: Update to 0.9.0
ClosedPublic
Actions

Authored by loader on Mar 17 2018, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 24, 10:06 PM
Unknown Object (File)
Fri, Nov 21, 2:49 PM
Unknown Object (File)
Fri, Nov 21, 11:51 AM
Unknown Object (File)
Fri, Nov 21, 11:50 AM
Unknown Object (File)
Fri, Nov 21, 11:44 AM
Unknown Object (File)
Fri, Nov 21, 11:40 AM
Unknown Object (File)
Oct 18 2025, 6:29 AM
Unknown Object (File)
Oct 16 2025, 4:41 AM
View All 93 Files
Subscribers
mat

Details

Reviewers
koobs
Commits
rP464993: mail/py-pymailq: Update to 0.9.0
Summary

Proposed commit log message:

mail/py-pymailq: Update to 0.9.0

- Use setup.py to install the man page

Reviewed_by: koobs
Approved by: koobs (ports)
Differential_Revision: D14722
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: 1200060, [armv7, aarch64], '', [py27, py36] tested)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

loader created this revision.Mar 17 2018, 4:18 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 17 2018, 4:18 PM
Harbormaster completed remote builds in B15618: Diff 40384.Mar 17 2018, 4:18 PM
loader edited the summary of this revision. (Show Details)Mar 17 2018, 4:19 PM
koobs requested changes to this revision.Mar 18 2018, 10:01 AM
koobs added inline comments.
mail/py-pymailq/files/patch-setup.py
14 ↗(On Diff #40384)

What was the issue here? The change isn't noted in the commit log message

This revision now requires changes to proceed.Mar 18 2018, 10:01 AM
loader added inline comments.Mar 18 2018, 2:00 PM
mail/py-pymailq/files/patch-setup.py
14 ↗(On Diff #40384)

The man page file was moved from setup.py data_files to Makefile, so it could be installed for different Python versions.

post-install:
	​        ${INSTALL_MAN} ${WRKSRC}/man/pqshell.1 ${STAGEDIR}${MANPREFIX}/man/man1/pqshell-${PYTHON_VER}.1
.if ${PYTHON_VERSION} == ${PYTHON_DEFAULT_VERSION}
	​        ${LN} -sf pqshell-${PYTHON_VER}.1 ${STAGEDIR}${MANPREFIX}/man/man1/pqshell.1
​.endif

matt@ has committed a patch to handle man page files:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220214

It's okay to let setup.py install the man page file now.

loader edited the summary of this revision. (Show Details)Mar 18 2018, 2:19 PM
koobs edited the summary of this revision. (Show Details)Mar 19 2018, 5:09 AM
koobs accepted this revision.Mar 19 2018, 5:12 AM
koobs added inline comments.
mail/py-pymailq/files/patch-setup.py
14 ↗(On Diff #40384)

Feel free to give it a go adding the new [1] uniquefiles man page handling feature support to Uses/python.mk now that it has landed

[1] https://svnweb.freebsd.org/changeset/ports/456737

This revision is now accepted and ready to land.Mar 19 2018, 5:12 AM
loader added a comment.Mar 19 2018, 7:32 AM

Thanks, @koobs .

Closed by commit rP464993: mail/py-pymailq: Update to 0.9.0 (authored by loader). · Explain WhyMar 19 2018, 7:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
mail/
py-pymailq/
11 lines
6 lines
files/
8 lines

Diff 40433

View Options

head/mail/py-pymailq/Makefile

Loading...
View Options

head/mail/py-pymailq/distinfo

Loading...
View Options

head/mail/py-pymailq/files/patch-setup.py

Loading...