Tags

None

Referenced Files

	F105815196: D14641.diff
	Sat, Dec 21, 2:43 AM

	Unknown Object (File)
	Wed, Dec 18, 11:26 AM

	Unknown Object (File)
	Wed, Dec 18, 11:23 AM

	Unknown Object (File)
	Wed, Dec 18, 11:23 AM

	Unknown Object (File)
	Wed, Dec 18, 11:22 AM

	Unknown Object (File)
	Sat, Dec 14, 8:07 PM

	Unknown Object (File)
	Mon, Dec 9, 10:45 PM

	Unknown Object (File)
	Mon, Dec 9, 10:17 PM

View All Files

Subscribers

None

Details

Reviewers

mat

Group Reviewers

kde
portmgr

Commits

rP467319: multimedia/gstreamer1-qt4, multimedia/gstreamer1-qt5: create flavors

Summary

makes flavour out of the slave port

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15488
Build 15530: arc lint + arc unit

Event Timeline

tcberner created this revision.Mar 10 2018, 8:29 PM

Harbormaster completed remote builds in B15473: Diff 40137.Mar 10 2018, 8:29 PM

mat added inline comments.Mar 11 2018, 9:41 AM

multimedia/gstreamer1-qt/Makefile
8	Would probably be simpler to change PORTNAME to gstreamer1 and use -${FLAVOR} here.
27–41	This should happen later, see Chapter 15. Order of Variables in Port Makefiles.

Change portname, reorder Makefile

Harbormaster completed remote builds in B15487: Diff 40155.Mar 11 2018, 10:36 AM

tcberner added inline comments.Mar 11 2018, 10:37 AM

multimedia/gstreamer1-qt/Makefile
30	^ whait, this is now broken. let me fix that :)

Fix COMMENT and CMAKE_ARGS after PKGNAMESUFFIX change

Harbormaster completed remote builds in B15488: Diff 40156.Mar 11 2018, 10:41 AM

Fix CONFLICTS_INSTALL.

Harbormaster completed remote builds in B15489: Diff 40157.Mar 11 2018, 10:46 AM

mat accepted this revision as: portmgr.Mar 12 2018, 10:03 AM

mat added a reviewer: portmgr.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2018, 2:03 PM

Closed by commit rP467319: multimedia/gstreamer1-qt4, multimedia/gstreamer1-qt5: create flavors (authored by tcberner). · Explain Why

This revision was automatically updated to reflect the committed changes.

Flavorize multimedia/gstreamer1-qt[45] -> multimedia/gstreamer1-qt
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40156

MOVED

deskutils/lumina-mediaplayer/Makefile

graphics/kipi-plugin-videoslideshow/Makefile

misc/artikulate-kde4/Makefile

multimedia/Makefile

multimedia/gstreamer1-qt/

multimedia/gstreamer1-qt/Makefile

multimedia/gstreamer1-qt4/

multimedia/gstreamer1-qt4/Makefile

multimedia/gstreamer1-qt4/distinfo

multimedia/gstreamer1-qt4/files/

multimedia/gstreamer1-qt4/files/patch-git_1d2edcc9

multimedia/gstreamer1-qt4/files/patch-git_fc159e5c4

multimedia/gstreamer1-qt4/pkg-descr

multimedia/gstreamer1-qt4/pkg-plist

multimedia/gstreamer1-qt5/

multimedia/gstreamer1-qt5/Makefile

Flavorize multimedia/gstreamer1-qt[45] -> multimedia/gstreamer1-qtClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40156

MOVED

deskutils/lumina-mediaplayer/Makefile

graphics/kipi-plugin-videoslideshow/Makefile

misc/artikulate-kde4/Makefile

multimedia/Makefile

multimedia/gstreamer1-qt/

multimedia/gstreamer1-qt/Makefile

multimedia/gstreamer1-qt4/

multimedia/gstreamer1-qt4/Makefile

multimedia/gstreamer1-qt4/distinfo

multimedia/gstreamer1-qt4/files/

multimedia/gstreamer1-qt4/files/patch-git_1d2edcc9

multimedia/gstreamer1-qt4/files/patch-git_fc159e5c4

multimedia/gstreamer1-qt4/pkg-descr

multimedia/gstreamer1-qt4/pkg-plist

multimedia/gstreamer1-qt5/

multimedia/gstreamer1-qt5/Makefile

Flavorize multimedia/gstreamer1-qt[45] -> multimedia/gstreamer1-qt
ClosedPublic
Actions

Revision Contents
Changeset List