Page MenuHomeFreeBSD
Differential D13654

Add support for Sunrise Point-LP to ig4 iichbus.
ClosedPublic
Actions

Authored by ben_curlybracket.co.uk on Dec 27 2017, 6:44 PM.
Tags
None
Referenced Files
F169222787: D13654.id.diff
Mon, Aug 31, 10:38 PM
F169090637: D13654.id40018.diff
Mon, Aug 31, 9:30 AM
F169007908: D13654.id37101.diff
Mon, Aug 31, 2:59 AM
Unknown Object (File)
Sun, Aug 30, 10:59 PM
Unknown Object (File)
Sun, Aug 30, 9:05 PM
Unknown Object (File)
Sat, Aug 29, 5:50 PM
Unknown Object (File)
Sat, Aug 29, 2:09 PM
Unknown Object (File)
Sat, Aug 29, 9:15 AM
View All Files
Subscribers
imp

Details

Reviewers
gonzo
Commits
rS331834: MFC r330558:
rS330558: [ig4] Add support for i2c controllers on Skylake and Kaby Lake
Summary

This is mostly taken from the DragonflyBSD commit to the ig4 driver a4549657e6696a736bbe133ffe158bf59a0cd415 .

This adds support for Skylake and Kaby Lake to the ig4 driver.

I have tested this on a HP Chromebook 13 G1 with a Skylake CPU and Sunrise Point-LP I2C controller. I do not have any Atom or Haswell hardware to test against however, this should be tested to ensure that it hasn't regressed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ben_curlybracket.co.uk created this revision.Dec 27 2017, 6:44 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 27 2017, 6:44 PM
ben_curlybracket.co.uk updated this revision to Diff 37103.Dec 27 2017, 6:46 PM

Fix code style on ig4_iic.c:540

ben_curlybracket.co.uk updated this revision to Diff 37115.Dec 27 2017, 11:52 PM

Add full context to changed files.

gonzo added a comment.Feb 1 2018, 6:01 AM

Looks good to me. I will test it on Atom when I have a chance.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2018, 11:40 PM
Closed by commit rS330558: [ig4] Add support for i2c controllers on Skylake and Kaby Lake (authored by gonzo). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ichiic/
2 lines
78 lines
40 lines
19 lines
2 lines

Diff 40018

View Options

head/sys/dev/ichiic/ig4_acpi.c

Loading...
View Options

head/sys/dev/ichiic/ig4_iic.c

Loading...
View Options

head/sys/dev/ichiic/ig4_pci.c

Loading...
View Options

head/sys/dev/ichiic/ig4_reg.h

Loading...
View Options

head/sys/dev/ichiic/ig4_var.h

Loading...