Page MenuHomeFreeBSD
Differential D14137

Work around the lack of definition of union semun per POSIX.
ClosedPublic
Actions

Authored by brooks on Jan 30 2018, 9:22 PM.
Tags
None
Referenced Files
F146601770: D14137.id38889.diff
Wed, Mar 4, 12:24 AM
F146596623: D14137.id38981.diff
Tue, Mar 3, 11:23 PM
F146592683: D14137.id.diff
Tue, Mar 3, 10:35 PM
Unknown Object (File)
Mon, Mar 2, 6:18 PM
Unknown Object (File)
Mon, Mar 2, 6:42 AM
Unknown Object (File)
Mon, Mar 2, 1:05 AM
Unknown Object (File)
Sun, Mar 1, 8:03 PM
Unknown Object (File)
Sun, Mar 1, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
antoine
Commits
rP463452: Work around the lack of definition of union semun per POSIX.
Summary

When feasible do this by adding -D_WANT_SEMUN to CFLAGS or CXXFLAGS.
Where this fails due to ports not honoring C*FLAGS, patch using
__FreeBSD_version to enable the definition.

NOTE: the patches currently use the un-updated __FreeBSD_version value. This will be corrected at commit time.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14683
Build 14810: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 30 2018, 9:22 PM
Harbormaster completed remote builds in B14683: Diff 38689.Jan 30 2018, 9:22 PM
brooks added a comment.Jan 30 2018, 9:23 PM

See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224443

brooks updated this revision to Diff 38889.Feb 5 2018, 5:59 PM
  • One more -D_WANT_SEMUN after new exprun.
Harbormaster completed remote builds in B14792: Diff 38889.Feb 5 2018, 5:59 PM
brooks updated this revision to Diff 38981.Feb 6 2018, 11:14 PM
  • Work around the need for union semun, lack of mymsg, and struct name changes
Harbormaster completed remote builds in B14827: Diff 38981.Feb 6 2018, 11:14 PM
brooks updated this revision to Diff 39268.Feb 13 2018, 7:49 PM
  • Rebase
  • Remove no longer needed patches (fixed upstream and port updated).
brooks mentioned this in D14492: Don't declare union semun in userspace unless _WANT_SEMUN is defined..Feb 23 2018, 9:47 PM
brooks updated this revision to Diff 39667.Feb 23 2018, 9:53 PM
  • Update __FreeBSD_version to anticipated value.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 10:35 PM
Closed by commit rP463452: Work around the lack of definition of union semun per POSIX. (authored by brooks). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
audio/
alsa-lib/
1 line
gramofile/
1 line
wavplay/
2 lines
xmcd/
2 lines
zinf/
1 line
benchmarks/
super-smack/
1 line
databases/
fastdb/
1 line
devel/
ace/
1 line
libmba/
1 line
libshbuf/
1 line
nspr/
1 line
poco-ssl/
1 line
shmap/
1 line
emulators/
virtualbox-ose/
files/
22 lines
ftp/
gftp/
1 line
lang/
cint/
files/
20 lines
ferite/
1 line
rexx-regutil/
1 line
mail/
batv-milter/
1 line
files/
14 lines
dk-milter/
files/
14 lines
sendmail/
files/
14 lines
sid-milter/
files/
14 lines
misc/
buffer/
1 line
multimedia/
py-kaa-base/
1 line
net-mgmt/
sdig/
1 line
net-p2p/
monero-cli/
1 line
sysutils/
freeipmi/
1 line
symon/
1 line
www/
mod_cband/
files/
27 lines

Diff 38689

View Options

audio/alsa-lib/Makefile

Loading...
View Options

audio/gramofile/Makefile

Loading...
View Options

audio/wavplay/Makefile

Loading...
View Options

audio/xmcd/Makefile

Loading...
View Options

audio/zinf/Makefile

Loading...
View Options

benchmarks/super-smack/Makefile

Loading...
View Options

databases/fastdb/Makefile

Loading...
View Options

devel/ace/Makefile

Loading...
View Options

devel/libmba/Makefile

Loading...
View Options

devel/libshbuf/Makefile

Loading...
View Options

devel/nspr/Makefile

Loading...
View Options

devel/poco-ssl/Makefile

Loading...
View Options

devel/shmap/Makefile

Loading...
View Options

emulators/virtualbox-ose/files/patch-src_libs_xpcom18a4_nsprpub_pr_src_pthreads_ptsynch.c

Loading...
View Options

ftp/gftp/Makefile

Loading...
View Options

lang/cint/files/patch-cint_lib_ipc_ipcif.h

Loading...
View Options

lang/ferite/Makefile

Loading...
View Options

lang/rexx-regutil/Makefile

Loading...
View Options

mail/batv-milter/Makefile

Loading...
View Options

mail/batv-milter/files/patch-include_sm_os_sm__os__freebsd.h

Loading...
View Options

mail/dk-milter/files/patch-include_sm_os_sm__os__freebsd.h

Loading...
View Options

mail/sendmail/files/patch-include_sm_os_sm__os__freebsd.h

Loading...
View Options

mail/sid-milter/files/patch-include_sm_os_sm__os__freebsd.h

Loading...
View Options

misc/buffer/Makefile

Loading...
View Options

multimedia/py-kaa-base/Makefile

Loading...
View Options

net-mgmt/sdig/Makefile

Loading...
View Options

net-p2p/monero-cli/Makefile

Loading...
View Options

sysutils/freeipmi/Makefile

Loading...
View Options

sysutils/symon/Makefile

Loading...
View Options

www/mod_cband/files/patch-src_mod__cband.c

Loading...