Page MenuHomeFreeBSD
Differential D14004

Improve USES autoreconf argument checking; update comments
ClosedPublic
Actions

Authored by ak on Jan 21 2018, 5:20 AM.
Tags
None
Referenced Files
F116647422: D14004.id38269.diff
Thu, May 8, 6:34 PM
Unknown Object (File)
Mar 26 2025, 2:17 AM
Unknown Object (File)
Mar 23 2025, 4:27 AM
Unknown Object (File)
Mar 19 2025, 12:58 PM
Unknown Object (File)
Mar 13 2025, 8:42 AM
Unknown Object (File)
Mar 11 2025, 9:42 PM
Unknown Object (File)
Mar 10 2025, 10:30 AM
Unknown Object (File)
Mar 6 2025, 1:01 AM
View All Files
Subscribers
mat

Details

Reviewers
tijl
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP459824: - Update name of autoreconf WRKSRC variable in comment
Summary
  • Change configure dir from CONFIGURE_WRKSRC to AUTORECONF_WRKSRC
  • Fix a few ports with invalid USES autoreconf arguments
  • Add check for invalid USES autoreconf arguments

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ak created this revision.Jan 21 2018, 5:20 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 21 2018, 5:20 AM
ak updated this revision to Diff 38269.Jan 21 2018, 7:18 AM

Remove changes from reverted commit.

tijl accepted this revision.Jan 21 2018, 1:07 PM
mat added a comment.Jan 22 2018, 2:51 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

ak updated this revision to Diff 38344.Jan 23 2018, 6:40 AM

Regenerate the patch in arcanist format.

mat accepted this revision as: portmgr.Jan 23 2018, 1:57 PM

Do check that no new autoreconf:garbage appeared before committing :-)

This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2018, 9:41 AM
Closed by commit rP459824: - Update name of autoreconf WRKSRC variable in comment (authored by ak). · Explain Why
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: O5: Ports Framework.Jan 24 2018, 9:41 AM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
6 lines
devel/
dmake/
2 lines
papilio-loader/
2 lines
editors/
openoffice-4/
2 lines
openoffice-devel/
2 lines
emulators/
open-vm-tools/
2 lines
net/
mosh/
2 lines
security/
sshpass/
2 lines
sysutils/
flock/
2 lines
www/
mod_auth_openidc/
2 lines

Diff 38344

View Options

Mk/Uses/autoreconf.mk

Loading...
View Options

devel/dmake/Makefile

Loading...
View Options

devel/papilio-loader/Makefile

Loading...
View Options

editors/openoffice-4/Makefile

Loading...
View Options

editors/openoffice-devel/Makefile

Loading...
View Options

emulators/open-vm-tools/Makefile

Loading...
View Options

net/mosh/Makefile

Loading...
View Options

security/sshpass/Makefile

Loading...
View Options

sysutils/flock/Makefile

Loading...
View Options

www/mod_auth_openidc/Makefile

Loading...