Page MenuHomeFreeBSD
Differential D1851

Improve style/consistency among ports maintained by jbeich
ClosedPublic
Actions

Authored by jbeich on Feb 16 2015, 6:32 AM.
Tags
None
Referenced Files
F152950616: D1851.id3788.diff
Sat, Apr 18, 7:00 AM
F152950414: D1851.id3792.diff
Sat, Apr 18, 6:58 AM
F152950375: D1851.id3792.diff
Sat, Apr 18, 6:58 AM
F152942656: D1851.diff
Sat, Apr 18, 5:42 AM
Unknown Object (File)
Thu, Apr 16, 4:55 PM
Unknown Object (File)
Wed, Apr 15, 4:58 PM
Unknown Object (File)
Sun, Apr 12, 3:33 PM
Unknown Object (File)
Fri, Apr 10, 2:44 PM
View All Files
Subscribers
None

Details

Reviewers
bapt
Summary

Improve style/consistency among ports I maintain

  • Convert to COPYTREE_SHARE
  • Drop unnecessary MKDIR before COPYTREE_SHARE
  • Drop bsd.port.options.mk if only DOCS requires it without dependencies
  • Use separate backup if several REINPLACE_CMD against same file
  • audio/alsa-utils: convert to LIBS
Test Plan

poudriere bulk -t for 10.1R i386 logs:
alsa-utils-1.0.28.log
fusefs-simple-mtpfs-0.2.s20150108.log
katawa-shoujo-1.2.log
onscripter-20150208.log
openra-20141029_1.log
ponscripter-sekai-0.0.6.log
renpy-6.18.3.log
rlvm-0.14.log
transmission-cli-2.84_2.log
xsystem35-1.7.3.p5_2.log

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jbeich updated this revision to Diff 3788.Feb 16 2015, 6:32 AM
jbeich retitled this revision from to Improve style/consistency among ports maintained by jbeich.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: bapt.
jbeich added a comment.Feb 16 2015, 6:40 AM

Hmm, all those cases of

	${MKDIR} ${STAGEDIR}${DOCSDIR}
	${INSTALL_MAN} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}

can be replaced with

	(cd ${WRKSRC} && ${COPYTREE_SHARE} \
		"${PORTDOCS}" ${STAGEDIR}${DOCSDIR})
jbeich updated this revision to Diff 3792.Feb 16 2015, 7:03 AM
  • Convert INSTALL_MAN uses to COPYTREE_SHARE
jbeich updated this object.Feb 16 2015, 7:06 AM
bapt accepted this revision.Feb 16 2015, 7:53 AM
bapt edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2015, 7:53 AM
jbeich closed this revision.Feb 16 2015, 8:16 AM

Closed by commit rP379072 (authored by @jbeich).

Revision Contents
Changeset List

PathSize
audio/
alsa-utils/
5 lines
devel/
onscripter/
1 line
ponscripter-sekai/
9 lines
renpy/
2 lines
rlvm/
6 lines
emulators/
xsystem35/
12 lines
games/
katawa-shoujo/
11 lines
openra/
6 lines
net-p2p/
transmission-cli/
6 lines
sysutils/
fusefs-simple-mtpfs/
4 lines

Diff 3792

View Options

audio/alsa-utils/Makefile

Loading...
View Options

devel/onscripter/Makefile

Loading...
View Options

devel/ponscripter-sekai/Makefile

Loading...
View Options

devel/renpy/Makefile

Loading...
View Options

devel/rlvm/Makefile

Loading...
View Options

emulators/xsystem35/Makefile

Loading...
View Options

games/katawa-shoujo/Makefile

Loading...
View Options

games/openra/Makefile

Loading...
View Options

net-p2p/transmission-cli/Makefile

Loading...
View Options

sysutils/fusefs-simple-mtpfs/Makefile

Loading...