Page MenuHomeFreeBSD

[New Port]: misc/rumprun
ClosedPublic

Authored by fabian.freyer_physik.tu-berlin.de on Jan 12 2018, 6:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 4:59 AM
Unknown Object (File)
Jan 13 2025, 12:25 PM
Unknown Object (File)
Dec 4 2024, 12:21 PM
Unknown Object (File)
Nov 25 2024, 1:49 PM
Unknown Object (File)
Nov 24 2024, 5:12 PM
Unknown Object (File)
Nov 23 2024, 10:09 PM
Unknown Object (File)
Nov 23 2024, 10:34 AM
Unknown Object (File)
Nov 20 2024, 11:03 PM

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Hi, thanks for your nice work, would be nice of you if you answer some questions I have. ๐Ÿ˜„

misc/rumprun/Makefile
17

Can't we use USES=compiler options instead of USE_GCC ?

26

Why did you have to split your includes as .pre.mk and .post.mk? Anything I have missed about here?

misc/rumprun/Makefile
17

Unfortunately, no, it needs gcc.

26

You're right, I don't need to do this. I'll update the patch.

yuri added inline comments.
misc/rumprun/Makefile
17

Why does it need gcc? What isn't working with clang?

misc/rumprun/Makefile
5

The version should be g20180105.

misc/rumprun/Makefile
5

And it should be DISTVERSION, not PORTVERSION.

misc/rumprun/Makefile
5

Ah, I hadn't seen Example 5.14. Makes sense, I'll update the patch.

17

See https://github.com/rumpkernel/rumprun/blob/master/build-rr.sh#L305:

checktools ()
{

	# Check that a clang build is not attempted.
	[ -z "${BUILDRUMP_HAVE_LLVM}" ] \
	    || die rumprun does not yet support clang ${CC:+(\$CC: $CC)}

	delay=5

	# check that gcc is modern enough
	vers=$(${CC:-cc} -E -dM - < /dev/null | LANG=C awk '
	    /__GNUC__/ {version += 100*$3}
	    /__GNUC_MINOR__/ {version += $3}
	    END { print version; if (version) exit 0; exit 1; }') \
		|| unable to probe cc version
	if [ ${vers} -lt 406 ]; then
		die gcc is too old, need 4.6 or later. ${CC:+(\$CC: $CC)}
	elif [ ${vers} -lt 408 ]; then
		echo '>>'
		echo ">> WARNING: gcc is old. ${CC:+(\$CC: $CC)}"
		echo '>> Version 4.8 or later is recommended.'

Looks good to me.
If @yuri is also fine with it, I'll commit it.

About GCC i think it makes sense that it requires it since in netbsd the default is gcc AFAIK.
(however I'd go with fixing the build-with-Clang in long-term and upstream the fix).

Macro lgtm:

This revision is now accepted and ready to land.Jan 13 2018, 11:19 AM
This revision was automatically updated to reflect the committed changes.
head/misc/rumprun/Makefile
22 โ†—(On Diff #37922)

This is wrong. man pages should be installed in PREFIX/man, so the build or install script should be patched to put them at the right place.

@mat OH I see ๐Ÿ™ˆ (I'm so sorry that I didn't noticed that before ๐Ÿ˜… ๐Ÿ™ )
We have another PR open, and in committing that I'll also fix this as well before committing.