Details
- Reviewers
mmokhi - Commits
- rP458940: misc/rumprun: Add port to the tree
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
misc/rumprun/Makefile | ||
---|---|---|
17 | Why does it need gcc? What isn't working with clang? |
misc/rumprun/Makefile | ||
---|---|---|
5 | The version should be g20180105. |
misc/rumprun/Makefile | ||
---|---|---|
5 | And it should be DISTVERSION, not PORTVERSION. |
misc/rumprun/Makefile | ||
---|---|---|
5 | Ah, I hadn't seen Example 5.14. Makes sense, I'll update the patch. | |
17 | See https://github.com/rumpkernel/rumprun/blob/master/build-rr.sh#L305: checktools () { # Check that a clang build is not attempted. [ -z "${BUILDRUMP_HAVE_LLVM}" ] \ || die rumprun does not yet support clang ${CC:+(\$CC: $CC)} delay=5 # check that gcc is modern enough vers=$(${CC:-cc} -E -dM - < /dev/null | LANG=C awk ' /__GNUC__/ {version += 100*$3} /__GNUC_MINOR__/ {version += $3} END { print version; if (version) exit 0; exit 1; }') \ || unable to probe cc version if [ ${vers} -lt 406 ]; then die gcc is too old, need 4.6 or later. ${CC:+(\$CC: $CC)} elif [ ${vers} -lt 408 ]; then echo '>>' echo ">> WARNING: gcc is old. ${CC:+(\$CC: $CC)}" echo '>> Version 4.8 or later is recommended.' |
Looks good to me.
If @yuri is also fine with it, I'll commit it.
About GCC i think it makes sense that it requires it since in netbsd the default is gcc AFAIK.
(however I'd go with fixing the build-with-Clang in long-term and upstream the fix).
head/misc/rumprun/Makefile | ||
---|---|---|
22 โ | (On Diff #37922) | This is wrong. man pages should be installed in PREFIX/man, so the build or install script should be patched to put them at the right place. |
@mat OH I see ๐ (I'm so sorry that I didn't noticed that before ๐
๐ )
We have another PR open, and in committing that I'll also fix this as well before committing.