Differential D13654

Add support for Sunrise Point-LP to ig4 iichbus.
ClosedPublic
Actions

Authored by ben_curlybracket.co.uk on Dec 27 2017, 6:44 PM.

Details

Reviewers

gonzo

Commits

rS331834: MFC r330558:
rS330558: [ig4] Add support for i2c controllers on Skylake and Kaby Lake

Summary

This is mostly taken from the DragonflyBSD commit to the ig4 driver a4549657e6696a736bbe133ffe158bf59a0cd415 .

This adds support for Skylake and Kaby Lake to the ig4 driver.

I have tested this on a HP Chromebook 13 G1 with a Skylake CPU and Sunrise Point-LP I2C controller. I do not have any Atom or Haswell hardware to test against however, this should be tested to ensure that it hasn't regressed.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ben_curlybracket.co.uk created this revision.Dec 27 2017, 6:44 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2017, 6:44 PM

Fix code style on ig4_iic.c:540

Add full context to changed files.

Looks good to me. I will test it on Atom when I have a chance.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2018, 11:40 PM

Closed by commit rS330558: [ig4] Add support for i2c controllers on Skylake and Kaby Lake (authored by gonzo). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ichiic/

2 lines

79 lines

40 lines

19 lines

2 lines

Diff 37103

View Options

sys/dev/ichiic/ig4_acpi.c

View Options

sys/dev/ichiic/ig4_iic.c

View Options

sys/dev/ichiic/ig4_pci.c

View Options

sys/dev/ichiic/ig4_reg.h

View Options

Add support for Sunrise Point-LP to ig4 iichbus.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37103

sys/dev/ichiic/ig4_acpi.c

sys/dev/ichiic/ig4_iic.c

sys/dev/ichiic/ig4_pci.c

sys/dev/ichiic/ig4_reg.h

sys/dev/ichiic/ig4_var.h

Add support for Sunrise Point-LP to ig4 iichbus.
ClosedPublic
Actions

Revision Contents
Changeset List