Commit messages will be:
Reserrect net-mgmt/check_snmp_pkgvuln
make it work with pkg audit
take maintainership
Approved by: ? (mentor)
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Also, make sure you really resurrect the port and not add it as a new one. Follow the steps in the committer's guide.
Also, you need to remove it from the MOVED file.
| net-mgmt/check_snmp_pkgvuln/pkg-plist | ||
|---|---|---|
| 2 | You don't needs the @dir it's not empty. Did make makeplist generate that ? Also, as it's only one line, it could be added in the Makefile as: PLIST_FILES= ${NAGIOS_PLUGIN_DIR}/check_snmp_pkgvuln | |
| net-mgmt/check_snmp_pkgvuln/files/check_snmp_pkgvuln | ||
|---|---|---|
| 23 | paths to /usr/local should be replaced with the content of ${LOCALBASE} in that case. | |
Comment Actions
I'm stuck:
File /tmp//edit.8fw3847m73swkog0/differential-update-comments not changed so no update needed Linting... No lint engine configured for this project. Running unit tests... No unit test engine is configured for this project. Exception svn diff returned unexpected error code: 1 stdout: stderr: svn: E155035: Expected node '/usr/home/dan/working/freebsd/ports/net-mgmt/check_snmp_pkgvuln/distinfo' to be added. (Run with --trace for a full exception trace.)
I am removing distinfo, because there is no distfile. Not sure why things are barfing on this.
$ svn st net-mgmt/check_snmp_pkgvuln A + net-mgmt/check_snmp_pkgvuln M + net-mgmt/check_snmp_pkgvuln/Makefile D + net-mgmt/check_snmp_pkgvuln/distinfo A net-mgmt/check_snmp_pkgvuln/files A net-mgmt/check_snmp_pkgvuln/files/check_snmp_pkgvuln D + net-mgmt/check_snmp_pkgvuln/pkg-plist
| net-mgmt/check_snmp_pkgvuln/pkg-plist | ||
|---|---|---|
| 2 | No, make makeplist did not create that. I'll use PLIST_FILES | |
Comment Actions
zi raised a good point.
How do feel about renaming this from check_snmp_pkgvuln to nagios-check_snmp_pkgvuln?
Comment Actions
Don't really care one way or the other, there are a few ports named check_something, if you do, the MOVED entry should be updated to get the new origin.
Comment Actions
I think there's a problem with svn cp:
I've done an svn cp
- Updating D1785: Reserrect net-mgmt/check_snmp_pkgvuln #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
File /tmp//edit.8gmavyfx3bc4kw88/differential-update-comments saved
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
Exception
Command failed with error #1!
COMMAND
svn propget 'svn:mime-type' '/usr/ports/net-mgmt/nagios-check_snmp_pkgvuln'@
STDOUT
(empty)
STDERR
svn: warning: W200017: Property 'svn:mime-type' not found on '/usr/ports/net-mgmt/nagios-check_snmp_pkgvuln@'
svn: E200000: A problem occurred; see other errors for details
(Run with --trace for a full exception trace.)
Comment Actions
No, there's a problem with arcanist not being clever enough when you copy stuff around, you can't use it.