Page MenuHomeFreeBSD

Avoid the nbp lookup in the final loop iteration in flushbuflist()
ClosedPublic

Authored by markj on Oct 19 2017, 4:35 PM.
Tags
None
Referenced Files
F146986347: D12730.id34148.diff
Sat, Mar 7, 9:07 AM
F146970697: D12730.id.diff
Sat, Mar 7, 6:22 AM
Unknown Object (File)
Fri, Mar 6, 12:03 PM
Unknown Object (File)
Thu, Mar 5, 11:08 PM
Unknown Object (File)
Wed, Mar 4, 2:57 PM
Unknown Object (File)
Tue, Mar 3, 10:57 PM
Unknown Object (File)
Tue, Mar 3, 7:37 PM
Unknown Object (File)
Wed, Feb 25, 11:11 PM
Subscribers
None

Details

Summary

At the end of the final iteration, we have lblkno = xflags = 0 and thus
set nbp = gbincore(bo, 0). The xflags test will fail and cause the loop
to end, but this seems like a fragile and non-obvious mechanism. Modify
the test so that we break if nbp == NULL at the beginning of the loop.

No functional change intended; we just avoid an unnecessary lookup once
per call.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Avoid the inline assignment
This revision is now accepted and ready to land.Oct 19 2017, 5:24 PM
This revision was automatically updated to reflect the committed changes.