Page MenuHomeFreeBSD

Avoid the nbp lookup in the final loop iteration in flushbuflist()
ClosedPublic

Authored by markj on Oct 19 2017, 4:35 PM.
Tags
None
Referenced Files
F133641668: D12730.diff
Mon, Oct 27, 5:37 AM
Unknown Object (File)
Sat, Oct 18, 6:04 AM
Unknown Object (File)
Fri, Oct 17, 12:58 AM
Unknown Object (File)
Sat, Oct 11, 2:21 AM
Unknown Object (File)
Sat, Oct 11, 12:55 AM
Unknown Object (File)
Fri, Oct 10, 7:58 AM
Unknown Object (File)
Wed, Oct 1, 8:58 PM
Unknown Object (File)
Mon, Sep 29, 10:56 AM
Subscribers
None

Details

Summary

At the end of the final iteration, we have lblkno = xflags = 0 and thus
set nbp = gbincore(bo, 0). The xflags test will fail and cause the loop
to end, but this seems like a fragile and non-obvious mechanism. Modify
the test so that we break if nbp == NULL at the beginning of the loop.

No functional change intended; we just avoid an unnecessary lookup once
per call.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12126
Build 12427: arc lint + arc unit

Event Timeline

  • Avoid the inline assignment
This revision is now accepted and ready to land.Oct 19 2017, 5:24 PM
This revision was automatically updated to reflect the committed changes.