Page MenuHomeFreeBSD

Avoid the nbp lookup in the final loop iteration in flushbuflist()
ClosedPublic

Authored by markj on Oct 19 2017, 4:35 PM.
Tags
None
Referenced Files
F149634292: D12730.id34182.diff
Wed, Mar 25, 8:50 PM
F149558269: D12730.diff
Wed, Mar 25, 6:17 AM
Unknown Object (File)
Sat, Mar 21, 10:16 PM
Unknown Object (File)
Wed, Mar 11, 9:57 PM
Unknown Object (File)
Tue, Mar 10, 4:46 PM
Unknown Object (File)
Mon, Mar 9, 7:33 PM
Unknown Object (File)
Sat, Mar 7, 9:07 AM
Unknown Object (File)
Sat, Mar 7, 6:22 AM
Subscribers
None

Details

Summary

At the end of the final iteration, we have lblkno = xflags = 0 and thus
set nbp = gbincore(bo, 0). The xflags test will fail and cause the loop
to end, but this seems like a fragile and non-obvious mechanism. Modify
the test so that we break if nbp == NULL at the beginning of the loop.

No functional change intended; we just avoid an unnecessary lookup once
per call.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12126
Build 12427: arc lint + arc unit

Event Timeline

  • Avoid the inline assignment
This revision is now accepted and ready to land.Oct 19 2017, 5:24 PM
This revision was automatically updated to reflect the committed changes.