Page MenuHomeFreeBSD
Differential D12702

devel/py-python-pcre: updating to version 0.7
ClosedPublic
Actions

Authored by rigoletto on Oct 17 2017, 4:15 PM.
Tags
Referenced Files
F108464839: D12702.id36383.diff
Sat, Jan 25, 3:21 AM
F108462486: D12702.diff
Sat, Jan 25, 2:28 AM
Unknown Object (File)
Fri, Jan 24, 1:30 AM
Unknown Object (File)
Thu, Jan 23, 11:12 PM
Unknown Object (File)
Thu, Jan 23, 3:33 PM
Unknown Object (File)
Thu, Jan 23, 2:30 PM
Unknown Object (File)
Thu, Jan 23, 11:43 AM
Unknown Object (File)
Tue, Jan 21, 10:23 PM
View All 94 Files
Subscribers
AMDmi3
mat
Contributor Reviewers (ports)

Details

Reviewers
mat
AMDmi3
Commits
rP455781: - Update to 0.7
Summary
  • update to version 0.7
  • switch to DISTVERSION
  • add concurrent to USE_PYTHON
  • add STRIP_CMD as necessary.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12085
Build 12387: arc lint + arc unit

Event Timeline

rigoletto created this revision.Oct 17 2017, 4:15 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptOct 17 2017, 4:15 PM
Harbormaster completed remote builds in B12085: Diff 34064.Oct 17 2017, 4:15 PM
rigoletto added a project: Python.Oct 17 2017, 4:16 PM
mat requested changes to this revision.Oct 18 2017, 2:59 PM
mat added inline comments.
devel/py-python-pcre/Makefile
25

You removed the :2 qualifier from USES=python, but this is 2.7 only.

This revision now requires changes to proceed.Oct 18 2017, 2:59 PM
rigoletto updated this revision to Diff 34127.EditedOct 18 2017, 9:59 PM

Since the previous version was python:2 only, I think it is safe to assume a python:3 slave port is currently not necessary.
Reverting it to python:2 but maintaining concurrent for eventual future use.

Harbormaster completed remote builds in B12119: Diff 34127.Oct 18 2017, 9:59 PM
rigoletto updated this revision to Diff 36029.Dec 1 2017, 2:01 AM

Fixing.

Harbormaster completed remote builds in B13214: Diff 36029.Dec 1 2017, 2:01 AM
rigoletto marked an inline comment as done.EditedDec 1 2017, 2:55 AM

python-pcre currently does support Python 2 and 3:

https://github.com/awahlig/python-pcre/tree/v0.7

Thanks!

AMDmi3 added a subscriber: AMDmi3.Dec 6 2017, 1:30 PM
AMDmi3 added inline comments.
devel/py-python-pcre/Makefile
4

No need to use DISTVERSION here

15

No need for BUILD_DEPENDS line at all, since it duplicates LIB_DEPENDS.

AMDmi3 requested changes to this revision.Dec 6 2017, 1:30 PM
This revision now requires changes to proceed.Dec 6 2017, 1:30 PM
rigoletto updated this revision to Diff 36300.Dec 6 2017, 4:05 PM
rigoletto marked 2 inline comments as done.
  • switch back to PORTVERSION
  • remove BUILD_DEPENDS
Harbormaster completed remote builds in B13383: Diff 36300.Dec 6 2017, 4:05 PM
rigoletto added a comment.Dec 6 2017, 4:05 PM

Done

mat added inline comments.Dec 6 2017, 4:41 PM
devel/py-python-pcre/Makefile
4

DISTVERSION is the preferred way of expressing the version of a software, please do not go backwards.

rigoletto updated this revision to Diff 36304.Dec 6 2017, 4:46 PM
  • switch to DISTVERSION
Harbormaster completed remote builds in B13387: Diff 36304.Dec 6 2017, 4:46 PM
rigoletto marked an inline comment as done.Dec 6 2017, 4:47 PM

Done.

AMDmi3 added inline comments.Dec 6 2017, 7:41 PM
devel/py-python-pcre/Makefile
4

What's the reasoning behind that? I don't see any explanation in your sole commit to PHB.

https://github.com/freebsd/freebsd-doc/commit/716727dbaf5ca7d5d82b7393028dac5b72226229

mat added inline comments.Dec 7 2017, 11:54 AM
devel/py-python-pcre/Makefile
4

Because there are two way to look at it.

The bastard kind of way that has been there for the past 12 years where it was:

  • use PORTVERSION
  • if it does not work, use DISTVERSION
  • if it does not work, use PORTVERSION and DISTNAME

And there is the way that is now documented and that is much clearer:

  • Use DISTVERSION
  • If it does not work, use PORTVERSION and possibly DISTNAME.

The second one is much easier to explain.

AMDmi3 added inline comments.Dec 7 2017, 5:41 PM
devel/py-python-pcre/Makefile
4

Looks reasonable, as long as PORTVERSION stays allowed. One use for it is to preserve non-trivial upstream versions from mangling.

AMDmi3 accepted this revision.Dec 8 2017, 11:45 AM

I guess it's good now

Closed by commit rP455781: - Update to 0.7 (authored by AMDmi3). · Explain WhyDec 8 2017, 11:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
py-python-pcre/
11 lines
5 lines

Diff 34064

View Options

devel/py-python-pcre/Makefile

Loading...
View Options

devel/py-python-pcre/distinfo

Loading...