wlandebug(8): use new IEEE80211_IOC_UNIT ioctl request
AbandonedPublic
Actions

Authored by avos on Sep 30 2017, 11:11 PM.

Details

Reviewers

Summary

Try to get original interface unit number even when interface name was changed; use old method in case if something fails during request.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos created this revision.Sep 30 2017, 11:11 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2017, 11:11 PM

avos added a parent revision: D12552: net80211: export interface unit number via SIOCG80211 ioctl (IEEE80211_IOC_UNIT request type).Sep 30 2017, 11:12 PM

adrian accepted this revision.Sep 30 2017, 11:35 PM

adrian added inline comments.

usr.sbin/wlandebug/wlandebug.c
171	hm, should we put this in lib80211?

This revision is now accepted and ready to land.Sep 30 2017, 11:35 PM

avos added inline comments.Oct 1 2017, 12:09 AM

usr.sbin/wlandebug/wlandebug.c
171	interface name -> unit translation?

maybe the libifconfig thing that was done recently?

-a

avos mentioned this in D12555: wlandebug(8): obtain original interface name via ifconfig_get_orig_name().Oct 1 2017, 1:26 PM

nope; however, libifconfig seems to be more appropriate for such things (so there are alternative versions in D12554 (libifconfig) and D12555 (wlandebug)).

Version which uses libifconfig was accepted / committed instead.

Revision Contents
Changeset List

Path

Size

usr.sbin/

wlandebug/

Makefile

2 lines

wlandebug.c

36 lines

Diff 33598

View Options

usr.sbin/wlandebug/Makefile