3.21.01
ClosedPublic
Actions

Authored by bofh on Jan 22 2015, 12:57 PM.

Details

Reviewers

bapt
marino

Summary

Unbreak for GCC 4.9 [1]
Take maintainership

PR: 196912 [1]
Differential Revision: https://reviews.freebsd.org/DXXXX
Submitted by: gerald [1]
Approved by: xxxx(mentor)

Test Plan

http://pdr.s.ubze.ro/bulk/latest-per-pkg/libbobcat/3.21.01/

Rebuilt after the changes.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bofh updated this revision to Diff 3323.Jan 22 2015, 12:57 PM

bofh retitled this revision from to devel/libbobcat: Update version 3.18.01=>3.21.01.

bofh updated this object.

bofh edited the test plan for this revision. (Show Details)

bofh added reviewers: bapt, marino.

bofh set the repository for this revision to rP FreeBSD ports repository.

Can you update

+#ifdef FreeBSD
+#include <stdio.h>
+#endif
+

+#if defined( FreeBSD) || defined (DragonFly)
+#include <stdio.h>
+#endif
+

This revision now requires changes to proceed.Jan 22 2015, 1:03 PM

In D1598#4, @marino wrote:

Can you update

+#ifdef FreeBSD
+#include <stdio.h>
+#endif
+

to

+#if defined( FreeBSD) || defined (DragonFly)
+#include <stdio.h>
+#endif
+

??

Do I need a rebuild of poudriere logs after changing this?

no, it wouldn't change the outcome (assuming you don't make a typo)

Rather than ifdef FreeBSD only updated the patch for FreeBSD and DragonflyBSD

no.
The stupid review diff showed the changes without double-underscores (interpreting it as markup and making it underline the OS) and you copied it without the underscores.

Look at the actual email you got -- it shows he real diff.

e.g. it is "_ _ FreeBSD _ _" and "_ _ DragonFly _ _" without spaces.

If you thought I was changing the FreeBSD define, I can see now why you asked about running poudriere again.

rework per previous 2 comments

This revision now requires changes to proceed.Jan 23 2015, 8:37 AM

In D1598#14, @marino wrote:

rework per previous 2 comments

I left watching the mails as per our previous discussion. And I was just trying to guess how on earth it's going to work without the underscores because that's how the macros are defined in GCC. Fortunately it worked 3:). OK let me work on it once more. And I know for sure that 2 underscores will work fine and hence I am not going for another build this time.