devel/libbobcat: Update version 3.18.01=>3.21.01

[bofh]

Summary

• Unbreak for GCC 4.9 [1]
• Take maintainership

PR: 196912 [1]
Differential Revision: https://reviews.freebsd.org/DXXXX
Submitted by: gerald [1]
Approved by: xxxx(mentor)

Test Plan

http://pdr.s.ubze.ro/bulk/latest-per-pkg/libbobcat/3.21.01/

Rebuilt after the changes.

[marino]

Can you update

+#ifdef FreeBSD
+#include <stdio.h>
+#endif
+

to

+#if defined( FreeBSD) || defined (DragonFly)
+#include <stdio.h>
+#endif
+

??

[bofh]

In D1598#4, @marino wrote:

Can you update

+#ifdef FreeBSD
+#include <stdio.h>
+#endif
+

to

+#if defined( FreeBSD) || defined (DragonFly)
+#include <stdio.h>
+#endif
+

??

Do I need a rebuild of poudriere logs after changing this?

[marino]

no, it wouldn't change the outcome (assuming you don't make a typo)

[bofh]

Rather than ifdef FreeBSD only updated the patch for FreeBSD and DragonflyBSD

[marino]

no.
The stupid review diff showed the changes without double-underscores (interpreting it as markup and making it underline the OS) and you copied it without the underscores.

Look at the actual email you got -- it shows he real diff.

e.g. it is "_ _ FreeBSD _ _" and "_ _ DragonFly _ _" without spaces.

[marino]

If you thought I was changing the FreeBSD define, I can see now why you asked about running poudriere again.

[marino]

rework per previous 2 comments

[bofh]

In D1598#14, @marino wrote:

rework per previous 2 comments

I left watching the mails as per our previous discussion. And I was just trying to guess how on earth it's going to work without the underscores because that's how the macros are defined in GCC. Fortunately it worked 3:). OK let me work on it once more. And I know for sure that 2 underscores will work fine and hence I am not going for another build this time.

[bofh]

Reworked as per previous comments.

[marino]

Thanks!

[bofh]

Committed r377728.