Page MenuHomeFreeBSD
Differential D12111

Make basic Broadcom I/O space reading functions work
ClosedPublic
Actions

Authored by kibab on Aug 23 2017, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 2:28 PM
Unknown Object (File)
Sun, Apr 20, 9:46 AM
Unknown Object (File)
Sun, Apr 20, 9:22 AM
Unknown Object (File)
Sun, Apr 20, 8:20 AM
Unknown Object (File)
Sun, Apr 20, 7:58 AM
Unknown Object (File)
Sun, Apr 20, 7:52 AM
Unknown Object (File)
Sun, Apr 20, 7:50 AM
Unknown Object (File)
Sun, Apr 20, 7:49 AM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rS323717: Make basic Broadcom I/O space reading functions work
Summary

It's now possible to use Broadcom functions to read
the I/O registers of SDIO card. The functions were copied from
the BSD-licensed Broadcom Linux driver as-is.
To make it possible, a small Linux compatibility layer was introduced.

Currently the card responds with the correct version number ("magic")
when reading the corresponding address.

Test Plan

compile the tool and run it against Broadcom-based SDIO WIFI chip.
I tested on Wandboard Quad where it hides behind pass1.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 11616
Build 11968: arc lint + arc unit

Event Timeline

kibab created this revision.Aug 23 2017, 8:05 PM
Harbormaster completed remote builds in B11215: Diff 32345.Aug 23 2017, 8:05 PM
imp accepted this revision.Sep 11 2017, 8:56 PM
This revision is now accepted and ready to land.Sep 11 2017, 8:56 PM
kibab updated this revision to Diff 33183.Sep 18 2017, 7:56 AM

Added files lost in the process of doing git rebase magic. PTAL

This revision now requires review to proceed.Sep 18 2017, 7:56 AM
kibab updated this revision to Diff 33184.Sep 18 2017, 8:03 AM

Added licenses for the code from Broadcom

Harbormaster completed remote builds in B11617: Diff 33184.Sep 18 2017, 8:03 AM
imp accepted this revision.Sep 18 2017, 2:45 PM
This revision is now accepted and ready to land.Sep 18 2017, 2:45 PM
Closed by commit rS323717: Make basic Broadcom I/O space reading functions work (authored by kibab). · Explain WhySep 18 2017, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
sdiotool/
2 lines
9 lines
143 lines
95 lines
440 lines
58 lines
63 lines
104 lines
751 lines

Diff 33183

View Options

usr.bin/sdiotool/Makefile

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

usr.bin/sdiotool/brcmfmac_bus.h

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

usr.bin/sdiotool/brcmfmac_sdio.h

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

usr.bin/sdiotool/cam_sdio.h

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

usr.bin/sdiotool/cam_sdio.c

Loading...
View Options

usr.bin/sdiotool/linux_compat.h

Loading...
View Options

usr.bin/sdiotool/linux_sdio_compat.h

Loading...
View Options

usr.bin/sdiotool/linux_sdio_compat.c

Loading...
View Options

usr.bin/sdiotool/sdiotool.c

Loading...