Make yaml-cpp usable on HEAD by software that wants C++17.
ClosedPublic
Actions

Authored by ed on Sep 9 2017, 6:29 AM.

Details

Reviewers

madpilot
mat

Commits

rP449589: Make yaml-cpp usable on HEAD for software that wants C++17.

Summary

yaml-cpp uses auto_ptr in a small number of places. This is problematic,
as libc++ 5.0.0 (used on HEAD) has auto_ptr disabled when building for
C++17. This causes the build for cloudabi-utils to fail on HEAD.

Instead of removing all of the use of auto_ptr from yaml-cpp, this
commit only changes public header files to make use of unique_ptr.

As I also ran into this issue for CloudABI, here's a bug report I filed
upstream a couple of weeks ago:

https://github.com/jbeder/yaml-cpp/issues/523

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed created this revision.Sep 9 2017, 6:29 AM

ed retitled this revision from Make yaml-cpp on HEAD by software that wants C++17. to Make yaml-cpp usable on HEAD by software that wants C++17..Sep 9 2017, 7:08 AM

mat accepted this revision.Sep 9 2017, 8:15 AM

This revision is now accepted and ready to land.Sep 9 2017, 8:15 AM

madpilot accepted this revision.Sep 10 2017, 10:59 AM

Closed by commit rP449589: Make yaml-cpp usable on HEAD for software that wants C++17. (authored by ed). · Explain WhySep 10 2017, 7:36 PM

This revision was automatically updated to reflect the committed changes.