Paths

Table of Contentst

benchmarks/unixbench: updating to version 5.1.3
ClosedPublic
Actions

Authored by pizzamig on Sep 4 2017, 2:41 PM.

Details

Reviewers

olivier
lme

Commits

rP449273: benchmarks/unixbench: updating to version 5.1.3

Summary

Updating to the last version, hosted now on github

Moreover:

updating MAINTAINER entry
changing build and installation phases to adopt the new structure
adding the proper dependencies

Reviewed by\: mat
Approved by\: olivier (mentor)
Approved by\: lme (mentor)
Differential Revision\: https://reviews.freebsd.org/D12224

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 11364
Build 11727: arc lint + arc unit

Event Timeline

pizzamig created this revision.Sep 4 2017, 2:41 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 4 2017, 2:41 PM

mat added inline comments.Sep 4 2017, 3:30 PM

benchmarks/unixbench/Makefile
5–6	You could also switch to using `DISTVERSION`.
16–24	Why not simply use: BUILD_WRKSRC= ${WRKSRC}/UnixBench Or, as it seems you have many, many occurrences of `${WRKSRC}/UnixBench` later, simply: WRKSRC_SUBDIR= UnixBench
44–45	I cannot see any case where this MKDIR could fail and it should not be fatal.
45–47	This is also done in an easier way. Either: ${INSTALL_DATA} ${WRKSRC}/UnixBench/testdir/* ${STAGEDIR}${PREFIX}/libexec/unixbench/testdir/ or cd ${WRKSRC}/UnixBench/testdir/ && ${COPYTREE_SHARE} . ${STAGEDIR}${PREFIX}/libexec/unixbench/testdir/

olivier added inline comments.Sep 4 2017, 3:47 PM

benchmarks/unixbench/Makefile
11	Is there a typo here regarding this double quote ?

Adopting suggested solutions
Fixing typos
Rebuilding patches

Harbormaster completed remote builds in B11364: Diff 32648.Sep 4 2017, 8:54 PM

pizzamig marked 5 inline comments as done.Sep 4 2017, 8:55 PM

pizzamig edited the summary of this revision. (Show Details)

olivier accepted this revision.Sep 4 2017, 10:21 PM

This revision is now accepted and ready to land.Sep 4 2017, 10:21 PM

Closed by commit rP449273: benchmarks/unixbench: updating to version 5.1.3 (authored by pizzamig). · Explain WhySep 5 2017, 7:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

benchmarks/

unixbench/

Makefile

63 lines

distinfo

5 lines

files/

patch-Makefile

42 lines

patch-Run

130 lines

patch-pgms_cleanup.sh

4 lines

6 lines

11 lines

2 lines

11 lines

4 lines

2 lines

71 lines

Commit	Tree	Parents	Author	Summary	Date
f6157661a725	0105bedf619d	b8cff87c39c4	Luca Pizzamiglio	Invoked make makepatch	Sep 4 2017, 8:43 PM
b8cff87c39c4	b4841b4d0b7b	23f35ceabd29	Luca Pizzamiglio	Rework of the port version and fixing portlint issues	Sep 4 2017, 8:42 PM
23f35ceabd29	7857aa5da358	5be45eed0b74	Luca Pizzamiglio	Using better knowledge to do the same thing (Show More…)	Sep 4 2017, 8:36 PM
5be45eed0b74	3c8b66d5f8be	6165fea6ad30 0546c3493688	Luca Pizzamiglio	Merge branch 'F-unixbench' of https://github.com/pizzamig/freebsd-ports into F… (Show More…)	Sep 4 2017, 2:27 PM
6165fea6ad30	a3bddba75dc1	583901ce4123	Luca Pizzamiglio	Restoring unixbench and fixing 10.3 build	Sep 4 2017, 2:26 PM
0546c3493688	d55096056284	fa4a3372100a	Luca Pizzamiglio	Adding x11perf as dependency	Sep 4 2017, 1:38 PM
fa4a3372100a	b6c75fb54a41	583901ce4123 cd42a1abe4f6	Luca Pizzamiglio	Mergin master	Sep 4 2017, 11:45 AM
583901ce4123	8533c3c5f2b0	8dfa826bc18b	Luca Pizzamiglio	Fixing description and message	Sep 4 2017, 11:42 AM
8dfa826bc18b	d79f20587828	ab15e8a159f9	Luca Pizzamiglio	Moving results on /tmp	Sep 4 2017, 10:57 AM
ab15e8a159f9	5193d7beb236	ae4fe6bda970	Luca Pizzamiglio	Adding some patches to remove warnings	Sep 4 2017, 10:53 AM
ae4fe6bda970	ae19a2099de8	21ed18285a93	Luca Pizzamiglio	Fixing pkg-plist	Sep 4 2017, 10:44 AM
21ed18285a93	2c62869821c9	a1c1f3608454	Luca Pizzamiglio	Moving everything under libexec instead of lib	Sep 4 2017, 10:41 AM
a1c1f3608454	8b629b540099	0514f6f9c735	Luca Pizzamiglio	Adding several small fixed in the Run script	Sep 4 2017, 10:41 AM
0514f6f9c735	69ecb098482e	3725c2d1d60d	Luca Pizzamiglio	Fixing the tst.sh script	Sep 4 2017, 10:29 AM
3725c2d1d60d	503ccef23e30	6655f654feef	Luca Pizzamiglio	Reworking the installation phase and adopting proper perl5 usage	Sep 4 2017, 9:14 AM
6655f654feef	3fbe79d193ff	d00e7da94ae7 31bfde6a60af	Luca Pizzamiglio	Mergin master	Sep 1 2017, 10:07 AM
d00e7da94ae7	a97cc3249b8c	ff176da77e20	Luca Pizzamiglio	Fixing the install target	Sep 1 2017, 9:10 AM
ff176da77e20	2e199076d534	93b922801119	Luca Pizzamiglio	Temporarily Run patch removal	Aug 31 2017, 8:23 PM
93b922801119	4ab84e49ebb5	9d2b9080c861	Luca Pizzamiglio	Renaming or removing obsolete patches	Aug 31 2017, 3:52 PM
9d2b9080c861	1f76c106ac13	263b9f590594	Luca Pizzamiglio	Adopting the renewed layout provided by the github version (Show More…)	Aug 31 2017, 3:50 PM
263b9f590594	5ca3fa7cdee3	60ffbb9313ad	Luca Pizzamiglio	Removing a patch of a removed file	Aug 30 2017, 9:20 PM
60ffbb9313ad	8e99d3e8fa4f	368fa4910183 c9519992d0ff	Luca Pizzamiglio	Mergin master	Aug 30 2017, 4:09 PM
368fa4910183	e6174752bee4	b4d09112a3ad	Luca Pizzamiglio	Initial work updating benchmarks/unixbench	Aug 23 2017, 11:00 AM