This is ugly, is there a better way to implement this? I couldn't come up with any.

I have been pondering adding a USE_GITLAB to the framework, have not found the time yet, though.

I'll create a draft, I'm not sure if adding USE_GITLAB and reusing the code for github is the better solution though. Simply adding a new variable that will change the root domain like: GH_DOMAIN, or GH_SITE and setting it to https://gitlab.com. The latter also has the benefit of allow users using gitlab on there own domain to be set so it maybe a better solution.

It could be a little more confusing to not have the variable as GITLAB though, so maybe it would be best to create a new USE with the domain change option. This is probably the best solution.

Thoughts?

's/root//' I wish I could edit the comment.

Adding USE_GITLAB, with GH_SITE, GH_ACCOUNT, GH_PROJECT, GH_COMMIT is what I had in miond :-)
Reusing the USE_GITHUB bit also, but not too much, they look the same, but are very different :-)
It should be named GITLAB because it would work with the gitlab application, wether it is on gitlab.com, or on a personnal installation.

Yeah, wish you could have replied about 4 hours sooner. Realize just how different the two are... Not a complete loss though I understand the USE_GITHUB code much better now. Your plan sounds good, one question though what is the reason for adding GH_COMMIT over reusing GH_TAGNAME?

Ah, I mistyped, habits, I meant GL_ prefix for each. And it needs a GL_COMMIT because it is needed because WRKSRC contains the commit hash. So as it is required anyway, might as well have it. (And no, I really do not think a post-extract target moving things around is the way to go.)