Differential D11825

Make nvd vs nda choice boot-time rather than build-time
ClosedPublic
Actions

Authored by imp on Aug 2 2017, 6:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 11, 2:48 PM

	Unknown Object (File)
	Sat, Apr 11, 11:00 AM

	Unknown Object (File)
	Tue, Apr 7, 4:07 AM

	Unknown Object (File)
	Sat, Apr 4, 2:01 AM

	Unknown Object (File)
	Sat, Apr 4, 1:12 AM

	Unknown Object (File)
	Fri, Apr 3, 6:27 AM

	Unknown Object (File)
	Sat, Mar 28, 1:10 AM

	Unknown Object (File)
	Sun, Mar 15, 6:44 AM

Subscribers

None

Details

Reviewers

scottl
jimharris

Commits

rS322036: Make nvd vs nda choice boot-time rather than build-time

Summary

Introduce hw.nvme.use_nvd tunable. This tunable allows both nvd and
nda to be installed in the kernel, while allowing only one of them to
create devices. This is an all-or-nothing setting, and you can't
change it after boot-time. However, it will allow easier A/B testing.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10812
Build 11205: arc lint + arc unit

Event Timeline

imp created this revision.Aug 2 2017, 6:48 PM

Harbormaster completed remote builds in B10812: Diff 31485.Aug 2 2017, 6:48 PM

imp added reviewers: scottl, jimharris.Aug 2 2017, 6:48 PM

Code all looks good. Just a couple of typos.

sys/dev/nvme/nvme_sysctl.c
38	NVMe is the typical abbreviation (lower case e).
40	deviecs => devices

This revision now requires changes to proceed.Aug 4 2017, 3:25 AM

Closed by commit rS322036: Make nvd vs nda choice boot-time rather than build-time (authored by imp). · Explain WhyAug 4 2017, 3:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

conf/

6 lines

2 lines

dev/

nvd/

7 lines

nvme/

6 lines

6 lines

Diff 31485

sys/conf/files

Loading...

sys/conf/files.amd64

Loading...

sys/dev/nvd/nvd.c

Loading...

sys/dev/nvme/nvme_sim.c

Loading...

sys/dev/nvme/nvme_sysctl.c

Loading...