Page MenuHomeFreeBSD
Differential D11413

qlnx: gcc build errors
ClosedPublic
Actions

Authored by rlibby on Jun 29 2017, 9:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 11:56 AM
Unknown Object (File)
Mon, Apr 14, 6:57 AM
Unknown Object (File)
Mon, Apr 14, 12:50 AM
Unknown Object (File)
Sun, Apr 13, 10:11 PM
Unknown Object (File)
Feb 11 2025, 7:06 AM
Unknown Object (File)
Feb 8 2025, 2:36 PM
Unknown Object (File)
Jan 30 2025, 1:43 AM
Unknown Object (File)
Dec 5 2024, 6:13 AM
View All 61 Files
Subscribers
markj

Details

Reviewers
davidcs
Commits
rS321106: qlnx: gcc build errors
Summary

Propagate warning flags from kern.opts.mk and then fix minor -Werror issues when building with gcc from -Wredundant-decls, -Wnested-externs, -Wuninitialized.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10206
Build 10627: arc lint + arc unit

Event Timeline

rlibby created this revision.Jun 29 2017, 9:33 PM
Harbormaster completed remote builds in B10206: Diff 30238.Jun 29 2017, 9:33 PM
rlibby added a comment.Jul 12 2017, 7:20 AM

Ping. This is a small patch to fix compilation of qlnx with gcc. It is mostly NFC (except for fixing a minor bug with an uninitialized variable which only affects debug logging).

davidcs accepted this revision.Jul 17 2017, 11:20 PM

The patch looks good.
thanks
David S. (davidcs@freebsd.org)

This revision is now accepted and ready to land.Jul 17 2017, 11:20 PM
markj added a comment.Jul 17 2017, 11:22 PM

Approved.

Closed by commit rS321106: qlnx: gcc build errors (authored by rlibby). · Explain WhyJul 18 2017, 6:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
qlnx/
qlnxe/
9 lines
5 lines
2 lines
modules/
qlnx/
2 lines
qlnxe/
6 lines

Diff 30238

View Options

sys/dev/qlnx/qlnxe/ecore_hw.h

Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Lines
#define DMAE_CMD_SIZE 14 #define DMAE_CMD_SIZE 14
/* size of DMAE command structure to fill.. DMAE_CMD_SIZE-5 */ /* size of DMAE command structure to fill.. DMAE_CMD_SIZE-5 */
#define DMAE_CMD_SIZE_TO_FILL (DMAE_CMD_SIZE - 5) #define DMAE_CMD_SIZE_TO_FILL (DMAE_CMD_SIZE - 5)
/* Minimum wait for dmae opertaion to complete 2 milliseconds */ /* Minimum wait for dmae opertaion to complete 2 milliseconds */
#define DMAE_MIN_WAIT_TIME 0x2 #define DMAE_MIN_WAIT_TIME 0x2
#define DMAE_MAX_CLIENTS 32 #define DMAE_MAX_CLIENTS 32
/** /**
* @brief ecore_gtt_init - Initialize GTT windows
*
* @param p_hwfn
* @param p_ptt
*/
void ecore_gtt_init(struct ecore_hwfn *p_hwfn,
struct ecore_ptt *p_ptt);
/**
* @brief ecore_ptt_invalidate - Forces all ptt entries to be re-configured * @brief ecore_ptt_invalidate - Forces all ptt entries to be re-configured
* *
* @param p_hwfn * @param p_hwfn
*/ */
void ecore_ptt_invalidate(struct ecore_hwfn *p_hwfn); void ecore_ptt_invalidate(struct ecore_hwfn *p_hwfn);
/** /**
* @brief ecore_ptt_pool_alloc - Allocate and initialize PTT pool * @brief ecore_ptt_pool_alloc - Allocate and initialize PTT pool
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines
View Options

sys/dev/qlnx/qlnxe/qlnx_ioctl.c

Show First 20 Lines • Show All 528 Lines • ▼ Show 20 Lines for (i = 0; i < ha->cdev.num_hwfns; i++) {
outb += regs->reg_buf_len; outb += regs->reg_buf_len;
} }
ha->grcdump_taken = 0; ha->grcdump_taken = 0;
return (rval); return (rval);
} }
extern char qlnx_name_str[];
extern char qlnx_ver_str[];
static int static int
qlnx_drv_info(qlnx_host_t *ha, qlnx_drvinfo_t *drv_info) qlnx_drv_info(qlnx_host_t *ha, qlnx_drvinfo_t *drv_info)
{ {
int i; int i;
extern char qlnx_name_str[];
extern char qlnx_ver_str[];
bzero(drv_info, sizeof(qlnx_drvinfo_t)); bzero(drv_info, sizeof(qlnx_drvinfo_t));
snprintf(drv_info->drv_name, sizeof(drv_info->drv_name), "%s", snprintf(drv_info->drv_name, sizeof(drv_info->drv_name), "%s",
qlnx_name_str); qlnx_name_str);
snprintf(drv_info->drv_version, sizeof(drv_info->drv_version), "%s", snprintf(drv_info->drv_version, sizeof(drv_info->drv_version), "%s",
qlnx_ver_str); qlnx_ver_str);
snprintf(drv_info->mfw_version, sizeof(drv_info->mfw_version), "%s", snprintf(drv_info->mfw_version, sizeof(drv_info->mfw_version), "%s",
▲ Show 20 Lines • Show All 313 Lines • Show Last 20 Lines
View Options

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...
View Options

sys/modules/qlnx/Makefile

Show All 26 Lines
#/* #/*
# * File : Makefile # * File : Makefile
# * Author : David C Somayajulu, Cavium, Inc., San Jose, CA 95131. # * Author : David C Somayajulu, Cavium, Inc., San Jose, CA 95131.
# */ # */
# #
# $FreeBSD$ # $FreeBSD$
# #
SYSDIR?=${SRCTOP}/sys
.include "${SYSDIR}/conf/kern.opts.mk"
SUBDIR=qlnxe SUBDIR=qlnxe
.include <bsd.subdir.mk> .include <bsd.subdir.mk>
View Options

sys/modules/qlnx/qlnxe/Makefile

Loading...