Page MenuHomeFreeBSD
Differential D11198

emulators/mupen64plus-qt: Basic launcher for Mupen64Plus
ClosedPublic
Actions

Authored by ultima on Jun 14 2017, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 1:21 PM
Unknown Object (File)
Thu, Dec 5, 8:59 AM
Unknown Object (File)
Nov 24 2024, 6:29 AM
Unknown Object (File)
Nov 24 2024, 6:29 AM
Unknown Object (File)
Nov 24 2024, 6:29 AM
Unknown Object (File)
Nov 24 2024, 6:29 AM
Unknown Object (File)
Nov 24 2024, 6:29 AM
Unknown Object (File)
Nov 24 2024, 6:16 AM
View All 77 Files
Subscribers
mat

Details

Reviewers
lifanov
matthew
Commits
rP443667: * Add mupen64plus-qt 1.10, basic launcher for Mupen64Plus.
Summary

Mupen64Plus-Qt is a basic launcher for the mupen64plus-ui-console frontend. It
was adapted from CEN64-Qt to work with Mupen64Plus.

See the README at https://www.github.com/dh4/mupen64plus-qt for a detailed
description of its features and usage.

WWW: https://www.github.com/dh4/mupen64plus-qt

PR\: 203642
Sumitted by\: Dan <dan465@mail.com> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

exp-run:
I have started the program on 12amd64 and appears to be working as intended.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9907
Build 10342: arc lint + arc unit

Event Timeline

ultima created this revision.Jun 14 2017, 9:36 PM
Herald added a subscriber: mat. · View Herald TranscriptJun 14 2017, 9:36 PM
Harbormaster completed remote builds in B9886: Diff 29620.Jun 14 2017, 9:36 PM
mat added inline comments.Jun 15 2017, 8:48 AM
emulators/mupen64plus-qt/Makefile
14

This is:

​RUN_DEPENDS= mupen64plus:emulators/mupen64plus
16–19

According to 13.1.17 here, https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order these lines are a bit out of order.

22

If using PORTDOCS, you must also add a:

OPTIONS_DEFINE=DOCS
35–36

You can then put this in a do-install-DOCS-on target.

ultima updated this revision to Diff 29657.Jun 15 2017, 2:04 PM

Thanks for pointing these out. I should not have missed all those...

Harbormaster completed remote builds in B9906: Diff 29657.Jun 15 2017, 2:04 PM
ultima updated this revision to Diff 29658.Jun 15 2017, 2:07 PM

Removed old docs install

Harbormaster completed remote builds in B9907: Diff 29658.Jun 15 2017, 2:07 PM
matthew accepted this revision.Jun 15 2017, 8:11 PM

This is a new port, so remember to use the addport script to add it. Note: you can add

Differential Revision: https://reviews.freebsd.org/D11198

to the commit message addport provides you with -- that will automatically close the review.

In any case:

lgtm

This revision is now accepted and ready to land.Jun 15 2017, 8:11 PM
Closed by commit rP443667: * Add mupen64plus-qt 1.10, basic launcher for Mupen64Plus. (authored by ultima). · Explain WhyJun 16 2017, 4:12 AM
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Jun 16 2017, 12:08 PM
head/emulators/mupen64plus-qt/Makefile
29 ↗(On Diff #29699)

This is not needed, the DOCS, EXAMPLES and NLS options are always on by default.

Revision Contents
Changeset List

PathSize
emulators/
mupen64plus-qt/
41 lines
3 lines
7 lines

Diff 29658

View Options

emulators/mupen64plus-qt/

Loading...
View Options

emulators/mupen64plus-qt/Makefile

Loading...
View Options

emulators/mupen64plus-qt/distinfo

Loading...
View Options

emulators/mupen64plus-qt/pkg-descr

Loading...