Page MenuHomeFreeBSD

Use BINUTILS_BOOTSTRAP only for binutils
ClosedPublic

Authored by emaste on Dec 30 2014, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 10:52 PM
Unknown Object (File)
Nov 21 2024, 4:54 AM
Unknown Object (File)
Nov 14 2024, 3:04 AM
Unknown Object (File)
Nov 7 2024, 10:34 PM
Unknown Object (File)
Nov 7 2024, 6:00 AM
Unknown Object (File)
Oct 12 2024, 5:35 PM
Unknown Object (File)
Oct 2 2024, 10:08 PM
Unknown Object (File)
Oct 2 2024, 6:43 PM
Subscribers
None

Details

Summary

For arm64 we disable BINUTILS and BINUTILS_BOOTSTRAP as the in-tree tools lack arm64 support. We can still use the elftoolchain tools in this case though.

Asking for review to see if you think this is sufficient, or if we should add ELFTOOLCHAIN_TOOLS_BOOTSTRAP or similar too.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to Use BINUTILS_BOOTSTRAP only for binutils.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: imp.
imp edited edge metadata.

This looks good to me. I think that as we've pulled in the elf tool chain, this was a mistake here. it isn't a subset of binutils. Many of the tools used to be part of binutils, but are no longer.

This points out a problem with XAS implying build arguments without actually setting them, but that's neither here nor there.

This revision is now accepted and ready to land.Dec 30 2014, 6:14 PM
emaste updated this revision to Diff 2922.

Closed by commit rS276414 (authored by @emaste).