D capability checks in sdhci.
ClosedPublic
Actions

Authored by ivadasz on May 30 2017, 8:37 PM.

Details

Reviewers

adrian
cognet
marius
jmcneill

Commits

rS319350: Fix typo in Driver Type A/C/D capability checks in sdhci.

Summary

Use the SDHCI_CAN_DRIVE_TYPE_A/_C/_D masks to check for Driver Type support,
instead of using the SDHCI_CTRL2_DRIVER_TYPE_A/_C/_D values which are meant
for setting the Driver Type in the HOST_CONTROL2 register.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivadasz created this revision.May 30 2017, 8:37 PM

The Driver Type capability bits are located in the CAPABILITIES2 register.

Harbormaster completed remote builds in B9584: Diff 29041.May 30 2017, 9:23 PM

Harbormaster completed remote builds in B9585: Diff 29042.

jmcneill accepted this revision.May 30 2017, 11:05 PM

This revision is now accepted and ready to land.May 30 2017, 11:05 PM

good catch!

I no longer seem to be able to add inline comments in this crappy review thing; while at it,
the second hunk involved in printing capabilities should be changed to operate based on
host_caps and MMC_CAP_DRIVER_TYPE_x as generally, only SDHCI_CAN_VDD_x don't
have corresponding bits in host_caps.

This revision now requires changes to proceed.May 31 2017, 7:20 PM

Closed by commit rS319350: Fix typo in Driver Type A/C/D capability checks in sdhci. (authored by ivadasz). · Explain WhyMay 31 2017, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sdhci/

sdhci.c

12 lines

Diff 29099

View Options

head/sys/dev/sdhci/sdhci.c

Fix typo in Driver Type A/C/D capability checks in sdhci.ClosedPublicActions