Add the SDHCI Address Decoder registers and routines for ARMADA 38X.
ClosedPublic
Actions

Authored by loos on May 4 2017, 7:27 PM.

Details

Reviewers

mw_semihalf.com
zbb

Commits

rS318336: Add the SDHCI Address Decoder registers and routines for ARMADA 38X.

Summary

Add the SDHCI Address Decoder registers and routines for ARMADA 38X.

Sponsored by: Rubicon Communications, LLC (Netgate)

Test Plan

Tested on ClearFog Pro.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9159
Build 9596: CI src build	Jenkins
Build 9595: arc lint + arc unit

Event Timeline

loos created this revision.May 4 2017, 7:27 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptMay 4 2017, 7:27 PM

loos retitled this revision from Add the SDHCI Address Decoder registers and routines for ARMADA 38X. Sponsored by: Rubicon Communications, LLC (Netgate) to Add the SDHCI Address Decoder registers and routines for ARMADA 38X.Sponsored by: Rubicon Communications, LLC (Netgate).May 4 2017, 7:30 PM

loos added reviewers: mw_semihalf.com, zbb.

loos retitled this revision from Add the SDHCI Address Decoder registers and routines for ARMADA 38X.Sponsored by: Rubicon Communications, LLC (Netgate) to Add the SDHCI Address Decoder registers and routines for ARMADA 38X..May 4 2017, 7:44 PM

loos edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B9073: Diff 28035.May 4 2017, 8:04 PM

loos mentioned this in D10606: Enable the SDHCI controller on ARMADA38X.May 5 2017, 3:18 AM

mw_semihalf.com added inline comments.May 5 2017, 7:21 AM

sys/arm/mv/mv_common.c
2090	Hi, I know e.g. usb3 is done exactly same, but I think the only place we should use the ifdef is here: static int decode_win_sdhci_valid(void) { #ifdef SOC_MV_ARMADA38X return (decode_win_can_cover_ddr(MV_WIN_SDHCI_MAX)); #endif /* Satisfy platforms not equipped with this controller */ return (1); } The registers definition are not under ifdef, so e.g. kirkwood should compile easily. _setup and _dump functions execution is depending on the compatible string, so it can be safe as well. In further perspective, I think also _valid check should depend on the compatible, so that we don't have to add dummy stuff. What do you think?

Remove the #ifdef for decode_win_sdhci_valid() as requested by Marcin at Semihalf.

sys/arm/mv/mv_common.c
2090	Fixed in the latest update. Thanks!

Harbormaster completed remote builds in B9147: Diff 28162.May 9 2017, 6:46 AM

mw_semihalf.com added inline comments.May 9 2017, 8:04 AM

sys/arm/mv/mv_common.c
669	Thanks for the update. However, if you move WIN_REG_BASE_IDX_ macros out of #if defined(SOC_MV_ARMADA38X)...
2128	... you will be able to remove ifdef around decode_win_sdhci_setup/dump and the dummy functions below. We won't break Kirkwood or ArmadaXP compilation, and because the routines won't execute on those platforms, because they require compatible string match.