Various 8259 device model improvements.
ClosedPublic
Actions

Authored by neel on Dec 17 2014, 6:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 11:41 AM

	Unknown Object (File)
	Thu, Dec 19, 8:59 AM

	Unknown Object (File)
	Fri, Dec 13, 6:01 AM

	Unknown Object (File)
	Nov 23 2024, 9:25 AM

	Unknown Object (File)
	Nov 12 2024, 10:58 PM

	Unknown Object (File)
	Oct 14 2024, 7:03 PM

	Unknown Object (File)
	Oct 14 2024, 7:02 PM

	Unknown Object (File)
	Oct 14 2024, 6:44 PM

View All 67 Files

Subscribers

None

Details

Reviewers

grehan
tychon
jhb

Commits

rS275952: Various 8259 device model improvements:

Summary

Various 8259 device model improvements:

implement 8259 "polled" mode.
set 'atpic->sfn' if bit 4 in ICW4 is set during master initialization.
report error if guest tries to enable the "special mask" mode.

Reported and tested by Peter Grehan (grehan@).

Test Plan

Prior to this change, when installing Centos4.8/i386, bhyve exits due to an
unhandled i/o port access. This was tracked down to the vatpic, with polled
mode not being implemented.

After this change the installation works as expected.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

neel updated this revision to Diff 2769.Dec 17 2014, 6:07 AM

neel retitled this revision from to Various 8259 device model improvements..

neel updated this object.

neel edited the test plan for this revision. (Show Details)

neel added reviewers: tychon, grehan, jhb.

So odd that SFN was implemented minus the ability to actually enable it. Seems like the priority to commit jumped the priority to complete ;-)

Thanks for finishing it! The changes look good to me.

This revision is now accepted and ready to land.Dec 19 2014, 3:24 PM

neel closed this revision.Dec 20 2014, 4:11 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

io/

vatpic.c

41 lines

Diff 2769

View Options

Various 8259 device model improvements.ClosedPublicActions