Differential D10378

UEFI support in vmrun.sh
ClosedPublic
Actions

Authored by lattera-gmail.com on Apr 12 2017, 11:53 PM.

Details

Reviewers

allanjude

Commits

rS329178: MFC: r316746 Add UEFI support to vmrun.sh
rS316746: Add UEFI support to vmrun.sh

Summary

This patch adds UEFI support in vmrun.sh/usr/share/examples/bhyve/vmrun.sh -E

Test Plan

pkg install uefi-edk2-bhyve tigervnc

Run vmrun.sh as you normally would, but pass in the -E option, which will cause bhyve to create a framebuffer, listening on 127.0.0.1:5900. You can use vncviewer from the tigervnc package to connect to the framebuffer.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lattera-gmail.com created this revision.Apr 12 2017, 11:53 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptApr 12 2017, 11:53 PM

allanjude added a subscriber: allanjude.Apr 12 2017, 11:57 PM

allanjude added inline comments.

share/examples/bhyve/vmrun.sh
55–56	lets keep -h, and use -L to control the IP we listen on.
225	add a helpful message telling them the name of the pkg to install?

Update to address Allan's comments.

lattera-gmail.com marked 2 inline comments as done.Apr 13 2017, 12:01 AM

allanjude accepted this revision.Apr 13 2017, 12:02 AM

allanjude added inline comments.

share/examples/bhyve/vmrun.sh
49	you forgot to re-add -h here, but I'll fix that before I commit it

This revision is now accepted and ready to land.Apr 13 2017, 12:02 AM

Closed by commit rS316746: Add UEFI support to vmrun.sh (authored by allanjude). · Explain WhyApr 13 2017, 12:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

share/

examples/

bhyve/

vmrun.sh

74 lines

Diff 27392

View Options

share/examples/bhyve/vmrun.sh

UEFI support in vmrun.shClosedPublicActions