Paths

Table of Contentst

-
audio/cmus/
-
cmus/
6/6
Makefile
6/6
distinfo
-
files/
6/6
patch-Makefile
6/6
patch-configure
-
patch-ffmpeg.c
-
patch-ip_mp4.c
-
patch-mp4.c
-
patch-sndio.c
-
pkg-plist

audio/cmus: Update to 2.8.0-rc0
ClosedPublic
Actions

Authored by tobik on Apr 3 2017, 10:19 AM.

Details

Reviewers

lme
mat

Commits

rP438165: Update to 2.8.0-rc0

Summary

Update to 2.8.0-rc0

- Fix build with devel/ncurses installed [1], which erroneously
  redefines _POSIX_C_SOURCE as 200112L globally via its pkg-config
  file and hides strndup from cmus.  A workaround for this was applied
  to cmus in DPorts commit d2907fe but it never made it back to
  FreeBSD.

Changes:	https://github.com/cmus/cmus/releases/tag/v2.8.0-rc0

PR:		216325, 214475 [1]
Reported by:	Oleg Gushchenkov <gor@clogic.com.ua> [1]
Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D?????

Test Plan

poudriere testport 10.3/i386 ok
poudriere testport 11.0/amd64 ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8452
Build 8749: arc lint + arc unit

Event Timeline

tobik created this revision.Apr 3 2017, 10:19 AM

mat requested changes to this revision.Apr 3 2017, 11:45 AM

mat added inline comments.

audio/cmus/Makefile
5–7	This should be `DISTVERSION=2.8.0-rc0`. Otherwise, when 2.8.0 gets released, you will have to do ugly things like bumping PORTREVISION.

This revision now requires changes to proceed.Apr 3 2017, 11:45 AM

Use DISTVERSION

Harbormaster completed remote builds in B8452: Diff 26949.Apr 3 2017, 11:59 AM

Is it ok to commit now?

mat accepted this revision.Apr 10 2017, 1:17 PM

This revision is now accepted and ready to land.Apr 10 2017, 1:17 PM

Closed by commit rP438165: Update to 2.8.0-rc0 (authored by tobik). · Explain WhyApr 10 2017, 1:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

audio/

cmus/

Makefile

25 lines

distinfo

10 lines

files/

13 lines

15 lines

3 lines

Diff 26949

View Options

audio/cmus/Makefile

Show First 20 Lines • Show All 4,327 Lines • ▼ Show 20 Lines	for dir in $$(${ALL-DEPENDS-LIST}); do \
_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \		_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \
if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \		if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \
${ECHO_CMD} $${_p}; \		${ECHO_CMD} $${_p}; \
fi; \		fi; \
done		done

# Install missing dependencies from package		# Install missing dependencies from package
install-missing-packages:		install-missing-packages:
@_dirs=$$(${MISSING-DEPENDS-LIST}); \		@_dirs=$$(${MISSING-DEPENDS-LIST}); \
if [ -n "$${_dirs}" ]; then \		${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A"
		matUnsubmitted Done Inline Actions I would use `\| ${XARGS}` which will take care of that. mat: I would use `\| ${XARGS}` which will take care of that.
		0mpAuthorUnsubmitted Done Inline Actions Hmm, sure, although I think that tr is more explicit. 0mp: Hmm, sure, although I think that tr is more explicit.
		tobikUnsubmitted Done Inline Actions This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS} ${PKG_BIN} install -A"` or even better push the su outwards as much as possible `${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} ${PKG_BIN} install -A"` tobik: This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS}…
		0mpAuthorUnsubmitted Done Inline Actions We've tried that approach, @tobik. The problem is that then you cannot have interactive prompts from pkg (stdin is taken by xargs). 0mp: We've tried that approach, @tobik. The problem is that then you cannot have interactive…
		tobikUnsubmitted Done Inline Actions I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A" tobik: I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ``` ${ECHO_CMD}…
		0mpAuthorUnsubmitted Done Inline Actions Ha! I didn't know about this one! Thanks. 0mp: Ha! I didn't know about this one! Thanks.
${SU_CMD} "${PKG_BIN} install -A $$(${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g")"; \
fi

################################################################		################################################################
# Everything after here are internal targets and really		# Everything after here are internal targets and really
# shouldn't be touched by anybody but the release engineers.		# shouldn't be touched by anybody but the release engineers.
################################################################		################################################################

# This target generates an index entry suitable for aggregation into		# This target generates an index entry suitable for aggregation into
# a large index. Format is:		# a large index. Format is:
▲ Show 20 Lines • Show All 1,058 Lines • Show Last 20 Lines

View Options

audio/cmus/distinfo

Show First 20 Lines • Show All 4,327 Lines • ▼ Show 20 Lines	for dir in $$(${ALL-DEPENDS-LIST}); do \
_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \		_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \
if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \		if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \
${ECHO_CMD} $${_p}; \		${ECHO_CMD} $${_p}; \
fi; \		fi; \
done		done

# Install missing dependencies from package		# Install missing dependencies from package
install-missing-packages:		install-missing-packages:
@_dirs=$$(${MISSING-DEPENDS-LIST}); \		@_dirs=$$(${MISSING-DEPENDS-LIST}); \
if [ -n "$${_dirs}" ]; then \		${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A"
		matUnsubmitted Done Inline Actions I would use `\| ${XARGS}` which will take care of that. mat: I would use `\| ${XARGS}` which will take care of that.
		0mpAuthorUnsubmitted Done Inline Actions Hmm, sure, although I think that tr is more explicit. 0mp: Hmm, sure, although I think that tr is more explicit.
		tobikUnsubmitted Done Inline Actions This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS} ${PKG_BIN} install -A"` or even better push the su outwards as much as possible `${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} ${PKG_BIN} install -A"` tobik: This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS}…
		0mpAuthorUnsubmitted Done Inline Actions We've tried that approach, @tobik. The problem is that then you cannot have interactive prompts from pkg (stdin is taken by xargs). 0mp: We've tried that approach, @tobik. The problem is that then you cannot have interactive…
		tobikUnsubmitted Done Inline Actions I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A" tobik: I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ``` ${ECHO_CMD}…
		0mpAuthorUnsubmitted Done Inline Actions Ha! I didn't know about this one! Thanks. 0mp: Ha! I didn't know about this one! Thanks.
${SU_CMD} "${PKG_BIN} install -A $$(${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g")"; \
fi

################################################################		################################################################
# Everything after here are internal targets and really		# Everything after here are internal targets and really
# shouldn't be touched by anybody but the release engineers.		# shouldn't be touched by anybody but the release engineers.
################################################################		################################################################

# This target generates an index entry suitable for aggregation into		# This target generates an index entry suitable for aggregation into
# a large index. Format is:		# a large index. Format is:
▲ Show 20 Lines • Show All 1,058 Lines • Show Last 20 Lines

View Options

audio/cmus/files/patch-Makefile

Show First 20 Lines • Show All 4,327 Lines • ▼ Show 20 Lines	for dir in $$(${ALL-DEPENDS-LIST}); do \
_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \		_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \
if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \		if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \
${ECHO_CMD} $${_p}; \		${ECHO_CMD} $${_p}; \
fi; \		fi; \
done		done

# Install missing dependencies from package		# Install missing dependencies from package
install-missing-packages:		install-missing-packages:
@_dirs=$$(${MISSING-DEPENDS-LIST}); \		@_dirs=$$(${MISSING-DEPENDS-LIST}); \
if [ -n "$${_dirs}" ]; then \		${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A"
		matUnsubmitted Done Inline Actions I would use `\| ${XARGS}` which will take care of that. mat: I would use `\| ${XARGS}` which will take care of that.
		0mpAuthorUnsubmitted Done Inline Actions Hmm, sure, although I think that tr is more explicit. 0mp: Hmm, sure, although I think that tr is more explicit.
		tobikUnsubmitted Done Inline Actions This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS} ${PKG_BIN} install -A"` or even better push the su outwards as much as possible `${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} ${PKG_BIN} install -A"` tobik: This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS}…
		0mpAuthorUnsubmitted Done Inline Actions We've tried that approach, @tobik. The problem is that then you cannot have interactive prompts from pkg (stdin is taken by xargs). 0mp: We've tried that approach, @tobik. The problem is that then you cannot have interactive…
		tobikUnsubmitted Done Inline Actions I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A" tobik: I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ``` ${ECHO_CMD}…
		0mpAuthorUnsubmitted Done Inline Actions Ha! I didn't know about this one! Thanks. 0mp: Ha! I didn't know about this one! Thanks.
${SU_CMD} "${PKG_BIN} install -A $$(${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g")"; \
fi

################################################################		################################################################
# Everything after here are internal targets and really		# Everything after here are internal targets and really
# shouldn't be touched by anybody but the release engineers.		# shouldn't be touched by anybody but the release engineers.
################################################################		################################################################

# This target generates an index entry suitable for aggregation into		# This target generates an index entry suitable for aggregation into
# a large index. Format is:		# a large index. Format is:
▲ Show 20 Lines • Show All 1,058 Lines • Show Last 20 Lines

View Options

audio/cmus/files/patch-configure

Show First 20 Lines • Show All 4,327 Lines • ▼ Show 20 Lines	for dir in $$(${ALL-DEPENDS-LIST}); do \
_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \		_p=$$(cd $$dir; ${MAKE} -VPKGNAME); \
if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \		if ! $$(${ECHO_CMD} $${_packages} \| ${GREP} -q $${_p}); then \
${ECHO_CMD} $${_p}; \		${ECHO_CMD} $${_p}; \
fi; \		fi; \
done		done

# Install missing dependencies from package		# Install missing dependencies from package
install-missing-packages:		install-missing-packages:
@_dirs=$$(${MISSING-DEPENDS-LIST}); \		@_dirs=$$(${MISSING-DEPENDS-LIST}); \
if [ -n "$${_dirs}" ]; then \		${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A"
		matUnsubmitted Done Inline Actions I would use `\| ${XARGS}` which will take care of that. mat: I would use `\| ${XARGS}` which will take care of that.
		0mpAuthorUnsubmitted Done Inline Actions Hmm, sure, although I think that tr is more explicit. 0mp: Hmm, sure, although I think that tr is more explicit.
		tobikUnsubmitted Done Inline Actions This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS} ${PKG_BIN} install -A"` or even better push the su outwards as much as possible `${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} ${PKG_BIN} install -A"` tobik: This should be `${SU_CMD} "${ECHO_CMD} \"$${_dirs}\" \| ${SED} 's%${PORTSDIR}/%%g' \| ${XARGS}…
		0mpAuthorUnsubmitted Done Inline Actions We've tried that approach, @tobik. The problem is that then you cannot have interactive prompts from pkg (stdin is taken by xargs). 0mp: We've tried that approach, @tobik. The problem is that then you cannot have interactive…
		tobikUnsubmitted Done Inline Actions I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g" \| ${SU_CMD} "${XARGS} -o ${PKG_BIN} install -A" tobik: I see. Luckily there seems to be an xargs(1) flag for exactly that, `-o`: ``` ${ECHO_CMD}…
		0mpAuthorUnsubmitted Done Inline Actions Ha! I didn't know about this one! Thanks. 0mp: Ha! I didn't know about this one! Thanks.
${SU_CMD} "${PKG_BIN} install -A $$(${ECHO_CMD} "$${_dirs}" \| ${SED} "s%${PORTSDIR}/%%g")"; \
fi

################################################################		################################################################
# Everything after here are internal targets and really		# Everything after here are internal targets and really
# shouldn't be touched by anybody but the release engineers.		# shouldn't be touched by anybody but the release engineers.
################################################################		################################################################

# This target generates an index entry suitable for aggregation into		# This target generates an index entry suitable for aggregation into
# a large index. Format is:		# a large index. Format is:
▲ Show 20 Lines • Show All 1,058 Lines • Show Last 20 Lines