New port: sysutils/solaar
ClosedPublic
Actions

Authored by tobik on Mar 27 2017, 10:48 PM.

Details

Reviewers

lme
mat

Commits

rP437119: New port: sysutils/solaar

Summary

Solaar is a device manager for Logitech's Unifying Receiver.  It is
able to pair/unpair devices to the receiver, and for most devices read
battery status.

It comes in two flavors, command-line and GUI.  Both are able to list
the devices paired to a Unifying Receiver, show detailed info for each
device, and also pair/unpair supported devices with the receiver.

WWW: https://pwr.github.io/Solaar/

Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D?????

Test Plan

poudriere testport 11.0/amd64 ok
poudriere testport 10.3/i386 ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8319
Build 8581: arc lint + arc unit

Event Timeline

tobik created this revision.Mar 27 2017, 10:48 PM

Harbormaster completed remote builds in B8319: Diff 26710.Mar 27 2017, 10:48 PM

tobik added inline comments.Mar 27 2017, 10:56 PM

sysutils/solaar/Makefile
13	Should this be a LIB_DEPENDS or is this ok? Solaar loads `libhidapi.so` via ctypes (dlopen).

mat added inline comments.Mar 28 2017, 8:33 AM

sysutils/solaar/Makefile
13	If it is not needed at build-time, then RUN_DEPENDS is ok. Also LIB_DEPENDS may have a special treatment (I'm not sure it does) as in it may only be registered if pkg finds the .so in the elf files. Also, add a comment before the RUN_DEPENDS line saying that it is only loaded at runtime, so that someone does not change it later on.
21	I was about to ask why you did not use the latest release tag (but it's 4 years old) so I'm going to say something else, when you find a github probject that stopped tagging releases, it may be nice to open an issue there asking gently for them to do so :-)
25–27	Add a GUI option that installs it ?
sysutils/solaar/files/patch-setup.py
12	This is probably wrong, 0.9.2 is from 2013.

Add GUI option, and comments about releases and RUN_DEPENDS

Harbormaster completed remote builds in B8331: Diff 26725.Mar 28 2017, 9:52 AM

tobik added inline comments.Mar 28 2017, 10:16 AM

sysutils/solaar/files/patch-setup.py
12	Yes, but that is what's defined in `lib/solaar/__init__py`. The import here fails for some reason and I decided to just define `NAME` and `__version__` myself with the original values. 0.9.2 appears to be hardcoded in several other places, too.