Differential D1032

In preparation for switching linuxulator to the use the native 1:1 threads refactor kern_sched_rr_get_interval() and sys_sched_rr_get_interval(). Add a kern_sched_rr_get_interval() counterpart which takes a targettd parameter to allow specify...
ClosedPublic
Actions

Authored by dchagin on Oct 31 2014, 6:19 AM.

Details

Reviewers

trasz

Group Reviewers

Linux Emulation

Commits

rS283374: In preparation for switching linuxulator to the use the native 1:1

Summary

...target thread directly by callee (new Linuxulator).

Linuxulator temporarily uses first thread in proc.

Move linux_sched_rr_get_interval() to the MI part.

While here rename e to a better name error.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2162.Oct 31 2014, 6:19 AM

dchagin retitled this revision from to In preparation for switching linuxulator to the use the native 1:1 threads refactor kern_sched_rr_get_interval() and sys_sched_rr_get_interval(). Add a kern_sched_rr_get_interval() counterpart which takes a targettd parameter to allow specify....

dchagin updated this object.

dchagin added a reviewer: Linux Emulation.Oct 31 2014, 6:52 AM

trasz added a subscriber: trasz.Dec 5 2014, 10:54 AM

trasz added inline comments.

sys/compat/linux/linux_misc.c
1937	Is the size and layout of l_timespec the same for 32 and 64 bit Linux binaries?
sys/kern/p1003_1b.c
317	Hm, another case of "asymetrical locking" - kern_sched_rr_get_interval_td() called with proc lock held, and dropping it, instead of leaving it to the caller.

dchagin added inline comments.Dec 6 2014, 4:17 PM

sys/compat/linux/linux_misc.c
1937	no, l_timespec machine dependent, declared in MD linux.h

Fixed asymetrical locking, leave unlocking to the caller.

trasz added inline comments.Dec 6 2014, 5:04 PM

sys/compat/linux/linux_misc.c
1937	How does it work for both 32 and 64 bit Linux binaries at the same time, then?

dchagin added inline comments.Dec 6 2014, 5:44 PM

sys/compat/linux/linux_misc.c
1937	not sure what understand the question correctly see lines 1952, 1953 linux_misc.c compiled twice, for linux64.ko and linux.ko. and for the linux.ko COMPAT_LINUX32 defined.