Page MenuHomeFreeBSD
Differential D9395

improve style
ClosedPublic
Actions

Authored by kczekirda on Jan 31 2017, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 8, 3:53 PM
Unknown Object (File)
Thu, Nov 6, 3:14 PM
Unknown Object (File)
Mon, Nov 3, 9:38 PM
Unknown Object (File)
Sun, Nov 2, 4:23 AM
Unknown Object (File)
Sun, Nov 2, 2:33 AM
Unknown Object (File)
Thu, Oct 30, 11:56 PM
Unknown Object (File)
Wed, Oct 29, 5:33 AM
Unknown Object (File)
Mon, Oct 27, 4:48 PM
View All Files
Subscribers
None

Details

Reviewers
bapt
oshogbo
Commits
rS314945: Some style(9) fixes. No functional changes.
Summary

no functional change

Sponsored by: Oktawave

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kczekirda updated this revision to Diff 24591.Jan 31 2017, 12:23 PM
kczekirda retitled this revision from to replacing spaces by tabs.
kczekirda updated this object.
kczekirda edited the test plan for this revision. (Show Details)
kczekirda added reviewers: oshogbo, bapt.
oshogbo requested changes to this revision.Feb 8 2017, 11:58 PM
oshogbo edited edge metadata.

Missing lines which need some love:
64, 130, 133, 134, 145, 155, 157, 166, 178, 427,

/usr/src/sys/boot/i386/libi386/pxe.c
224

[tab]printf(
[tab][4 spaces]args,

Described in styl(9).

228

up

231

up

250

4 spaces, not tab

257–258

Missing tab.

257–258

missing tab.
[tab]if (pxe_debug)
[tab][tab]sth.
style(9)

343–345

Sth, is wrong here, you can't have two } on same level ;(

353–354

MIssing tab, there are a lot missing tabs afters ifs, from this point, you will see them:

You can't have
if (sth)
sth2;

You need to have
if (sth)

sth2;
396

The same mistake with print as above.

This revision now requires changes to proceed.Feb 8 2017, 11:58 PM
kczekirda updated this revision to Diff 25141.Feb 14 2017, 10:30 AM
kczekirda retitled this revision from replacing spaces by tabs to improve style.
kczekirda edited edge metadata.
kczekirda marked 9 inline comments as done.

oshogbo's comments fixed and some new improvements

oshogbo accepted this revision.Feb 24 2017, 11:30 PM
oshogbo edited edge metadata.

It's looks good.

This revision is now accepted and ready to land.Feb 24 2017, 11:30 PM
Closed by commit rS314945: Some style(9) fixes. No functional changes. (authored by oshogbo). · Explain WhyMar 9 2017, 5:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr/
src/
sys/
boot/
i386/
libi386/
pxe.c
pxe.c-old
311 lines

Diff 25141

View Options

/usr/src/sys/boot/i386/libi386/pxe.c

Loading...