Page MenuHomeFreeBSD
Differential D9471

Update sysutils/py-glances to 2.8.1
ClosedPublic
Actions

Authored by krion on Feb 7 2017, 11:25 AM.
Tags
None
Referenced Files
F83690741: D9471.id24825.diff
Mon, May 13, 5:04 PM
F83690738: D9471.id24834.diff
Mon, May 13, 5:04 PM
F83690736: D9471.id.diff
Mon, May 13, 5:04 PM
F83690733: D9471.id24831.diff
Mon, May 13, 5:04 PM
Unknown Object (File)
Fri, May 10, 7:18 PM
Unknown Object (File)
Tue, May 7, 11:53 PM
Unknown Object (File)
Fri, May 3, 3:39 PM
Unknown Object (File)
Thu, Apr 25, 10:31 PM
View All 47 Files
Subscribers
None

Details

Reviewers
fjoe
mat
Commits
rP433556: Update sysutils/py-glances to 2.8.1
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216874

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7250
Build 7420: arc lint + arc unit

Event Timeline

krion updated this revision to Diff 24825.Feb 7 2017, 11:25 AM
krion retitled this revision from to Update sysutils/py-glances to 2.8.1.
krion updated this object.
krion edited the test plan for this revision. (Show Details)
krion added reviewers: mat, fjoe.
mat added inline comments.Feb 7 2017, 12:00 PM
sysutils/py-glances/Makefile
28

use ${ETCDIR} directly here.

krion added inline comments.Feb 7 2017, 12:20 PM
sysutils/py-glances/Makefile
28

OK, can you explain the rules of using ${ETCDIR} and %%ETCDIR%% in Makefiles nowadays?

mat added inline comments.Feb 7 2017, 12:29 PM
sysutils/py-glances/Makefile
28

%%foo%% expansions were created to allow carrying variables from the Makefile to pkg-plist.
Here, you are in the Makefile, you can use ${ETCDIR} directly, no need to use a placeholder that will get replaced back later.

krion updated this revision to Diff 24831.Feb 7 2017, 1:06 PM

s/%%ETCDIR%%/${ETCDIR}

mat accepted this revision.Feb 7 2017, 2:33 PM
mat edited edge metadata.
This revision is now accepted and ready to land.Feb 7 2017, 2:33 PM
Closed by commit rP433556: Update sysutils/py-glances to 2.8.1 (authored by krion). · Explain WhyFeb 7 2017, 2:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sysutils/
py-glances/
4 lines
6 lines
files/
6 lines

Diff 24831

View Options

sysutils/py-glances/Makefile

Loading...
View Options

sysutils/py-glances/distinfo

Loading...
View Options

sysutils/py-glances/files/patch-setup.py

Loading...