Page MenuHomeFreeBSD
Differential D9471

Update sysutils/py-glances to 2.8.1
ClosedPublic
Actions

Authored by krion on Feb 7 2017, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:15 AM
Unknown Object (File)
Tue, Oct 14, 5:07 PM
Unknown Object (File)
Mon, Oct 13, 1:25 AM
Unknown Object (File)
Mon, Oct 6, 3:01 AM
Unknown Object (File)
Fri, Sep 26, 11:50 AM
Unknown Object (File)
Sep 16 2025, 1:56 AM
Unknown Object (File)
Sep 4 2025, 1:35 AM
Unknown Object (File)
Aug 31 2025, 7:10 PM
View All Files
Subscribers
None

Details

Reviewers
fjoe
mat
Commits
rP433556: Update sysutils/py-glances to 2.8.1
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216874

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7247
Build 7417: arc lint + arc unit

Event Timeline

krion updated this revision to Diff 24825.Feb 7 2017, 11:25 AM
krion retitled this revision from to Update sysutils/py-glances to 2.8.1.
krion updated this object.
krion edited the test plan for this revision. (Show Details)
krion added reviewers: mat, fjoe.
mat added inline comments.Feb 7 2017, 12:00 PM
sysutils/py-glances/Makefile
28

use ${ETCDIR} directly here.

krion added inline comments.Feb 7 2017, 12:20 PM
sysutils/py-glances/Makefile
28

OK, can you explain the rules of using ${ETCDIR} and %%ETCDIR%% in Makefiles nowadays?

mat added inline comments.Feb 7 2017, 12:29 PM
sysutils/py-glances/Makefile
28

%%foo%% expansions were created to allow carrying variables from the Makefile to pkg-plist.
Here, you are in the Makefile, you can use ${ETCDIR} directly, no need to use a placeholder that will get replaced back later.

krion updated this revision to Diff 24831.Feb 7 2017, 1:06 PM

s/%%ETCDIR%%/${ETCDIR}

mat accepted this revision.Feb 7 2017, 2:33 PM
mat edited edge metadata.
This revision is now accepted and ready to land.Feb 7 2017, 2:33 PM
Closed by commit rP433556: Update sysutils/py-glances to 2.8.1 (authored by krion). · Explain WhyFeb 7 2017, 2:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sysutils/
py-glances/
2 lines
6 lines
files/
6 lines

Diff 24825

View Options

sysutils/py-glances/Makefile

Loading...
View Options

sysutils/py-glances/distinfo

Loading...
View Options

sysutils/py-glances/files/patch-setup.py

Loading...