Fix clang 3.5.0 warning in libngatm
ClosedPublic
Actions

Authored by dim on Nov 18 2014, 6:37 PM.

Details

Reviewers

emaste
rpaulo

Commits

rS274698: Fix the following -Werror warning from clang 3.5.0, while building

Summary

Fix the following -Werror warning from clang 3.5.0, while building lib/libngatm:

sys/contrib/ngatm/netnatm/saal/saal_sscop.c:4030:32: error: 'break' is bound to current loop, GCC binds it to the enclosing loop [-Werror,-Wgcc-compat]
                } while(sn < sscop->vr_h && !QFIND(&sscop->rbuf, sn));
                                             ^
sys/contrib/ngatm/netnatm/saal/saal_sscop.c:173:4: note: expanded from macro 'QFIND'
                        break;                                          \
                        ^
1 error generated.

The idea is to remove any ambiguity by replacing the macro with an equivalent static inline function.

Test Plan

Compile it, testing it in practice will be hard, as ngatm is mostly dead.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dim updated this revision to Diff 2451.Nov 18 2014, 6:37 PM

dim retitled this revision from to Fix clang 3.5.0 warning in libngatm.

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added reviewers: emaste, rpaulo.

related: http://reviews.llvm.org/D2518

Seems OK to me.

rpaulo accepted this revision.Nov 18 2014, 7:20 PM

rpaulo edited edge metadata.

This revision is now accepted and ready to land.Nov 18 2014, 7:20 PM

Closed by commit rS274698 (authored by @dim).

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ngatm/

netnatm/

saal/

saal_sscop.c

23 lines

Diff 2451

View Options

sys/contrib/ngatm/netnatm/saal/saal_sscop.c

Fix clang 3.5.0 warning in libngatmClosedPublicActions