databases/mysql56-server: Fix build with LibreSSL
ClosedPublic
Actions

Authored by brnrd on Jan 21 2017, 11:52 AM.

Details

Reviewers

mmokhi

Commits

rP432035: databases/mysql56-server: Fix build with LibreSSL

Summary

databases/mysql56-server: Fix build with LibreSSL

  - Fix CMake SSL detection
  - Always set WITH_SSL=${OPENSSLBASE}

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6925
Build 7113: arc lint + arc unit

brnrd retitled this revision from to databases/mysql56-server: Fix build with LibreSSL.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

brnrd added a reviewer: mmokhi.

I already worked on a patch and tested it,
Would you please check it too?

databases/mysql56-client/files/patch-cmake_ssl.cmake
2	The patch you have in 216311 should actually look for LIBRESSL_VERSION_NUMBER, not OPENSSL_MAJOR_VERSION. Not sure how to do that.
9	This is actually incorrect. With cmake 3.7 it should be VERSION_GREATER_EQUAL

databases/mysql56-client/files/patch-cmake_ssl.cmake
2	Using new variable (`LIBRESSL_VERSION_NUMBER` instead of `OPENSSL_MAJOR_VERSION`) is not necessary i guess, because the script will fill `OPENSSL_MAJOR_VERSION` with any found info inside `$OPENSSL_BASE`. Changing the name makes script much more readable though ;-) But currently it works.