rtwn: export more stats to net80211
ClosedPublic
Actions

Authored by avos on Jan 2 2017, 2:35 PM.

Details

Reviewers

kevlo
adrian

Commits

rS312315: rtwn: export more stats to net80211

Summary

Setup more ieee80211_rx_stats fields for received frames:

- pktflags:
  - IEEE80211_RX_F_FAIL_FCSCRC;
  - IEEE80211_RX_F_AMPDU;
  - IEEE80211_RX_F_AMPDU_MORE;
  - IEEE80211_RX_F_SHORTGI;
  - rate flags (CCK, OFDM, HT);
width;
phytype;
rate;
rx_tsf;
rssi;
nf;
ieee, freq (RTL8188EU only, when ht40 support is disabled).

Test Plan

Tested with:

RTL8188CE, STA, STA + AP modes.
RTL8188EU, STA, AP modes.
RTL8821AU, STA, AP mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 23530.Jan 2 2017, 2:35 PM

avos retitled this revision from to rtwn: export more stats to net80211..

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2017, 2:35 PM

I get a panic when bringing up the link on the wireless interface on -CURRENT:
http://imgur.com/a/lmiBl

adrian added inline comments.Jan 3 2017, 1:57 AM

sys/dev/rtwn/if_rtwn_rx.c
289	The intention of F_DECRYPTED right now is "the hardware decrypted a frame and is happily pretending it's an unencrypted frame." It looks like this doesn't do that - it instead just does payload decryption but doesn't clear M_WEP. I'll go document it in the header file so it makes more sense.

In rtl8812au/rtl8821au, since the rate mask in the rxdw3 field of Rx descriptor
is changed, we also need to replace R92C_RXDW3_RATE with R12A_RXDW3_RATE in
r12a_rx_radiotap_flags().

Remove IEEE80211_RX_F_DECRYPTED flag setup.
Call ieee80211_add_rx_params() in rtwn_rx_common() (and drop __DECONST); ieee80211_input_mimo() will check mbuf tag presence anyway.
Fix possible NULL pointer dereference (after ieee80211_find_rxnode() call).
Do not try to define R92C_RX_DRVINFO_SZ_DEF in if_rtwnvar.h; it is always included before r92c_reg.h.
Fix rate mask in r12a_rx_radiotap_flags().

avos marked an inline comment as done.Jan 12 2017, 12:19 AM