Page MenuHomeFreeBSD
Differential D1101

check-stagedir.sh improvement
ClosedPublic
Actions

Authored by antoine on Nov 3 2014, 8:34 PM.
Tags
None
Referenced Files
F150809270: D1101.id2278.diff
Sat, Apr 4, 5:05 AM
F150804323: D1101.id2256.diff
Sat, Apr 4, 4:12 AM
F150722008: D1101.id2278.diff
Fri, Apr 3, 3:05 PM
Unknown Object (File)
Thu, Apr 2, 1:03 PM
Unknown Object (File)
Thu, Apr 2, 3:12 AM
Unknown Object (File)
Tue, Mar 31, 1:36 PM
Unknown Object (File)
Sun, Mar 29, 3:46 AM
Unknown Object (File)
Sun, Mar 29, 2:46 AM
View All Files
Subscribers
bapt

Details

Reviewers
bapt
marino
Group Reviewers
portmgr
Commits
rP372177: - During makeplist, emit only empty directories inside prefix and
Summary
  • emit only empty directories in prefix and directories outside prefix during make-plist
  • whitelisting directories not starting with / is no longer needed during check-orphans after this (it was bogus anyway as %%DIRECTORYINROOT%% was not starting with /)
  • adjust missing dirs check to use a list of all directories instead of the dirs from make-plist

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

antoine updated this revision to Diff 2256.Nov 3 2014, 8:34 PM
antoine retitled this revision from to check-stagedir.sh improvement.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
antoine added a reviewer: marino.
Herald added a reviewer: portmgr. · View Herald TranscriptNov 3 2014, 8:34 PM
marino edited edge metadata.Nov 3 2014, 8:43 PM

Thanks for putting this together antoine!

antoine added a comment.Nov 4 2014, 10:56 AM

there is an orphan false positive for meta-ports, need to fix

> Checking for items in STAGEDIR missing from pkg-plist

Error: Orphaned: @dir /usr/local

antoine updated this revision to Diff 2265.Nov 4 2014, 12:52 PM
antoine edited edge metadata.

Fix false positive orphans for meta ports

bapt accepted this revision.Nov 4 2014, 11:29 PM
bapt added a reviewer: bapt.
bapt added a subscriber: bapt.

LGTM

This revision is now accepted and ready to land.Nov 4 2014, 11:29 PM
antoine closed this revision.Nov 5 2014, 7:15 AM
antoine updated this revision to Diff 2278.

Closed by commit rP372177 (authored by @antoine).

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
9 lines

Diff 2265

View Options

Mk/Scripts/check-stagedir.sh

Loading...