add marvell 88e6060 support on etherswitch
Details
Details
- Reviewers
mizhka loos adrian - Commits
- rS308699: [etherswitch] add Marvell 88e6060 switch support
FON2201 and IO-Data WN-G54/R3
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
| sys/dev/etherswitch/e6000sw/e6060sw.c | ||
|---|---|---|
| 69–73 ↗ | (On Diff #22101) | one of style(9) improvements is possible: add tab after #define |
| 95–102 ↗ | (On Diff #22101) | same - to be tab instead of space |
| 128 ↗ | (On Diff #22101) | space after "if" |
| 171 ↗ | (On Diff #22101) | space after "if" |
| 248 ↗ | (On Diff #22101) | space: i=0 => i = 0; |
Comment Actions
Does this need a committer to fire it off into head? I can take a look just to make sure it doesn't break anything obvious.
Comment Actions
@yamori813_yahoo.co.jp , do you have plan to merge it with e6000sw or add VLAN support?
Comment Actions
I'm happy with his going into the tree as-is. We can always unify these drivers more later.
Would someone mind please committing this to -head?
Comment Actions
@mizhka_gmail.com 88e6060 is not DOT1Q vlan support. It is Original Ingress and Egress Trailer. I think two way of support VLAN this chip. One is vlan(4) like support. Or other is interface driver code support. FON2201 original code use last one. But this is old chip I think leave alone is good. :)
Comment Actions
I have a few questions (yeah, I'm late, I know...)
I cannot find where or how e6000sw.c is connected to build. It is specific to some platform or board ? Is there a reason to no add it to sys/conf/files ?
It seems to also support the model 88E6176 which is used on ClearFog Pro. At some point we may need to find a solution to support DOT1Q.
Do you think it is possible @yamori813_yahoo.co.jp ? (maybe with docs ?)
Comment Actions
Nevermind about the 88e6176 comment, I was looking at the other file :/
But still, why these files are not linked to build ?