Page MenuHomeFreeBSD
Differential D8495

add infineon adm6996fc support on etherswitch
ClosedPublic
Actions

Authored by yamori813_yahoo.co.jp on Nov 11 2016, 12:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:31 PM
Unknown Object (File)
Oct 4 2024, 2:44 PM
Unknown Object (File)
Sep 22 2024, 6:36 AM
Unknown Object (File)
Sep 21 2024, 9:25 AM
Unknown Object (File)
Sep 17 2024, 7:00 AM
Unknown Object (File)
Sep 6 2024, 10:45 AM
Unknown Object (File)
Aug 24 2024, 6:18 PM
Unknown Object (File)
Aug 19 2024, 5:08 AM
View All 70 Files
Subscribers
mizhka

Details

Reviewers
mizhka
adrian
Commits
rS308744: [etherswitch] add infineon adm6996fc support on etherswitch
Summary

add infineon adm6996fc support on etherswitch

Test Plan

check on Netgear WGR614Cv7

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5944
Build 6225: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp updated this revision to Diff 22137.Nov 11 2016, 12:59 AM
yamori813_yahoo.co.jp retitled this revision from to add infineon adm6996fc support on etherswitch.
yamori813_yahoo.co.jp updated this object.
yamori813_yahoo.co.jp edited the test plan for this revision. (Show Details)
mizhka added a subscriber: mizhka.Nov 11 2016, 5:20 AM
  1. I see some "magic" constants. May be worth to add macros.
  2. DPRINTF usage: it prints function name on each call, is it useful/enough useful?
  3. "style(9)": ADM6996FC_READREG/WRITEREG - to be tab instead of space
  4. No checks on malloc results, may be NULL.
  5. Probe: can you add array of IDs to match. In future it will be easy to add IDs into array to bring support of another models.
sys/dev/etherswitch/infineon/adm6996fc.c
722–723

one empty line is enough ;)

yamori813_yahoo.co.jp updated this revision to Diff 22191.Nov 14 2016, 4:07 AM
  • review refict
yamori813_yahoo.co.jp updated this revision to Diff 22192.Nov 14 2016, 5:47 AM
  • add empty line
yamori813_yahoo.co.jp added a comment.Nov 14 2016, 5:59 AM
  1. add more macros.

2 This code is same as other ehterswitch code.

  1. add space.
  2. Other etherswitch code not check malloc also...
  3. Check only Product Code.
adrian accepted this revision.Nov 16 2016, 11:43 PM
adrian added a reviewer: adrian.
This revision is now accepted and ready to land.Nov 16 2016, 11:43 PM
mizhka accepted this revision.Nov 17 2016, 7:31 AM
mizhka added a reviewer: mizhka.
Closed by commit rS308744: [etherswitch] add infineon adm6996fc support on etherswitch (authored by mizhka). · Explain WhyNov 17 2016, 7:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
etherswitch/
infineon/
784 lines

Diff 22192

View Options

sys/dev/etherswitch/infineon/adm6996fc.c

Loading...